Commit 6ddd47f
committed
fix(examples): guard the baseline resource and repair what the extraction left behind
Removing majorMinor from the deck deleted the method but not its javadoc, so
the block was left heading logo() and documenting an @param version that
method does not take.
The showcase javadoc promised "three pages of designed content"; the document
renders two.
The examples job gates on the `code` path filter, which did not list
baselines/. Now that the module renders figures from the committed baseline, a
baseline-only refresh would have changed generated output while skipping the
job that checks it.
PerfBaseline degraded inconsistently: a missing resource was swallowed while a
malformed one threw from a static initializer and would have taken down every
example in the module, not just the one quoting a figure. Loading now never
throws, and a scenario whose figures are absent or non-numeric is treated as
absent rather than read as 0.0 - which would have rendered a plausible
"0.0 ms avg, 0 docs/sec" instead of admitting nothing was measured.
That fallback is honest at render time and wrong to discover in a published
PDF, so PerfBaselineTest asserts the resource really is on the classpath with
the scenarios the showcase quotes. Verified by pointing the pom entry at a
filename that does not exist: on a clean build two of its three tests fail with
the intended message.1 parent d964579 commit 6ddd47f
5 files changed
Lines changed: 80 additions & 17 deletions
File tree
- .github/workflows
- examples/src
- main/java/com/demcha/examples
- flagships
- support
- test/java/com/demcha/examples/support
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
82 | 85 | | |
83 | 86 | | |
84 | 87 | | |
| |||
Lines changed: 0 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
909 | 909 | | |
910 | 910 | | |
911 | 911 | | |
912 | | - | |
913 | | - | |
914 | | - | |
915 | | - | |
916 | | - | |
917 | | - | |
918 | | - | |
919 | | - | |
920 | | - | |
921 | 912 | | |
922 | 913 | | |
923 | 914 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
Lines changed: 28 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | | - | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
24 | 30 | | |
25 | 31 | | |
26 | 32 | | |
27 | 33 | | |
28 | 34 | | |
| 35 | + | |
| 36 | + | |
29 | 37 | | |
30 | 38 | | |
31 | 39 | | |
| |||
74 | 82 | | |
75 | 83 | | |
76 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
77 | 89 | | |
78 | 90 | | |
79 | | - | |
| 91 | + | |
80 | 92 | | |
81 | 93 | | |
82 | 94 | | |
83 | 95 | | |
84 | | - | |
85 | | - | |
86 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
87 | 108 | | |
88 | 109 | | |
89 | 110 | | |
90 | 111 | | |
91 | 112 | | |
92 | | - | |
93 | | - | |
| 113 | + | |
| 114 | + | |
94 | 115 | | |
95 | 116 | | |
96 | 117 | | |
Lines changed: 48 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
0 commit comments