Skip to content

Commit 966ccda

Browse files
authored
ci(workflow): drop hardcoded exec-maven-plugin:3.5.0 from benchmark steps (#80)
The three CI benchmark steps (perf smoke, full benchmark, benchmark diff) invoked org.codehaus.mojo:exec-maven-plugin:3.5.0:java directly, while benchmarks/pom.xml already declared exec-maven-plugin at 3.6.3 for local runs — a silent version split between CI and local invocations. Switching CI to exec:java resolves the plugin through benchmarks/pom.xml's build/plugins declaration (3.6.3), so there is only one version to bump. Reproduced locally: ./mvnw -B -ntp -f benchmarks/pom.xml -DskipTests exec:java \ -Dexec.mainClass=com.demcha.compose.CurrentSpeedBenchmark \ -Dgraphcompose.benchmark.profile=smoke → Performance gate passed for profile smoke (BUILD SUCCESS, 15s) Part of v1.6.5 publish hygiene (PR-7.1).
1 parent 0d30a27 commit 966ccda

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ jobs:
146146
- name: Run coarse performance smoke benchmark
147147
run: |
148148
./mvnw -B -ntp -f benchmarks/pom.xml -DskipTests \
149-
"org.codehaus.mojo:exec-maven-plugin:3.5.0:java" \
149+
exec:java \
150150
"-Dexec.mainClass=com.demcha.compose.CurrentSpeedBenchmark" \
151151
"-Dgraphcompose.benchmark.profile=smoke"
152152
@@ -194,7 +194,7 @@ jobs:
194194
- name: Run full benchmark suite
195195
run: |
196196
./mvnw -B -ntp -f benchmarks/pom.xml -DskipTests \
197-
"org.codehaus.mojo:exec-maven-plugin:3.5.0:java" \
197+
exec:java \
198198
"-Dexec.mainClass=com.demcha.compose.CurrentSpeedBenchmark" \
199199
"-Dgraphcompose.benchmark.profile=full" \
200200
"-Dgraphcompose.benchmark.enforceGate=false"
@@ -212,7 +212,7 @@ jobs:
212212
if: steps.benchmark-runs.outputs.count != '0' && steps.benchmark-runs.outputs.count != '1'
213213
run: |
214214
./mvnw -B -ntp -f benchmarks/pom.xml -DskipTests \
215-
"org.codehaus.mojo:exec-maven-plugin:3.5.0:java" \
215+
exec:java \
216216
"-Dexec.mainClass=com.demcha.compose.BenchmarkDiffTool" \
217217
"-Dexec.args=current-speed"
218218

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,15 @@ follow semantic versioning; release dates are ISO 8601.
5858
though no production code references it. Setting `<scope>test</scope>`
5959
keeps the version pin but keeps `byte-buddy` out of consumers' runtime
6060
classpath (`mvn dependency:tree` shows it only as `:test`).
61+
- **CI `exec-maven-plugin` version drift removed.** The CI workflow's
62+
three benchmark steps invoked
63+
`org.codehaus.mojo:exec-maven-plugin:3.5.0:java` directly, while
64+
`benchmarks/pom.xml` already declared `exec-maven-plugin` at `3.6.3`
65+
for local runs — a silent version split between CI and local invocations
66+
that grew the surface area to keep aligned. CI now calls the configured
67+
plugin via `exec:java`, picking up the pinned `3.6.3` from
68+
`benchmarks/pom.xml`. No behaviour change; one fewer hardcoded version
69+
to bump.
6170

6271
## v1.6.4 — 2026-05-22
6372

0 commit comments

Comments
 (0)