Fix ticket setup and panel creation

Author: Cyrusbye720

CHANGELOG.md

@@ -40,6 +40,8 @@ All notable changes to ZDiscord are documented here.
 - Confession embeds use a real love-letter emoji instead of a Discord shortcode.
 - Stat update events match the calling thread, fixing Paper quit-event crashes.
 - JDA SLF4J provider packaging fixed so startup does not use the fallback logger.
+- Ticket setup now uses the guided `/setup` wizard only and posts a ticket-specific setup flow.
+- Ticket creation ignores placeholder support-role IDs instead of aborting channel creation.
 - `/panel` no longer crashes in thread or forum channels.
 - `UpdateChecker` Discord announcement retries on failure.
 

src/main/java/dev/demonz/zdiscord/config/ConfigManager.java

@@ -10,6 +10,7 @@
 import java.io.InputStreamReader;
 import java.nio.file.Files;
 import java.nio.file.StandardCopyOption;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.function.Supplier;
 import java.util.logging.Logger;
@@ -18,7 +19,7 @@
 public class ConfigManager {
 
 
-    public static final int CURRENT_VERSION = 5;
+    public static final int CURRENT_VERSION = 6;
 
     private final File dataFolder;
     private final Logger logger;
@@ -45,6 +46,7 @@ public ConfigManager(File dataFolder,
         saveDefaultConfig();
         reload();
         migrateIfNeeded();
+        sanitizePlaceholders();
     }
 
     private void saveDefaultConfig() {
@@ -168,4 +170,26 @@ public void save() {
             logger.severe("Failed to save config: " + e.getMessage());
         }
     }
+
+    private void sanitizePlaceholders() {
+        List<String> roles = config.getStringList("tickets.support-roles");
+        if (roles.isEmpty()) {
+            return;
+        }
+
+        List<String> clean = new ArrayList<>();
+        boolean changed = false;
+        for (String role : roles) {
+            if (role == null || role.isBlank() || role.startsWith("YOUR_")) {
+                changed = true;
+            } else {
+                clean.add(role);
+            }
+        }
+
+        if (changed) {
+            config.set("tickets.support-roles", clean);
+            save();
+        }
+    }
 }

src/main/java/dev/demonz/zdiscord/discord/SetupCommand.java

@@ -1,6 +1,7 @@
 package dev.demonz.zdiscord.discord;
 
 import dev.demonz.zdiscord.ZDiscord;
+import dev.demonz.zdiscord.modules.TicketModule;
 import dev.demonz.zdiscord.util.ColorUtil;
 import dev.demonz.zdiscord.util.EmbedUtil;
 import dev.demonz.zdiscord.util.StatusEmbedBuilder;
@@ -10,13 +11,11 @@
 import net.dv8tion.jda.api.entities.Role;
 import net.dv8tion.jda.api.entities.channel.concrete.TextChannel;
 import net.dv8tion.jda.api.events.interaction.ModalInteractionEvent;
-import net.dv8tion.jda.api.events.interaction.command.CommandAutoCompleteInteractionEvent;
 import net.dv8tion.jda.api.events.interaction.command.SlashCommandInteractionEvent;
 import net.dv8tion.jda.api.events.interaction.component.ButtonInteractionEvent;
 import net.dv8tion.jda.api.events.interaction.component.EntitySelectInteractionEvent;
 import net.dv8tion.jda.api.events.interaction.component.StringSelectInteractionEvent;
 import net.dv8tion.jda.api.hooks.ListenerAdapter;
-import net.dv8tion.jda.api.interactions.commands.Command;
 import net.dv8tion.jda.api.interactions.components.ActionRow;
 import net.dv8tion.jda.api.interactions.components.buttons.Button;
 import net.dv8tion.jda.api.interactions.components.selections.EntitySelectMenu;
@@ -34,7 +33,6 @@
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.stream.Collectors;
 
 
 public class SetupCommand extends ListenerAdapter {
@@ -69,7 +67,7 @@ public class SetupCommand extends ListenerAdapter {
                 "Join, quit, death, and advancement events."));
         MODULES.put("console", new ModuleInfo("Console", "channels.console",
                 "Server console output streamed to Discord."));
-        MODULES.put("tickets", new ModuleInfo("Tickets", "channels.ticket-category",
+        MODULES.put("tickets", new ModuleInfo("Tickets", "tickets.panel-channel",
                 "Support ticket system with private channels."));
         MODULES.put("staffchat", new ModuleInfo("Staff Chat", "staff-chat.channel",
                 "Private staff communication bridge."));
@@ -83,8 +81,6 @@ public class SetupCommand extends ListenerAdapter {
                 "Anonymous confessions via /confess."));
     }
 
-    private static final List<String> MODULE_NAMES = new ArrayList<>(MODULES.keySet());
-
     public SetupCommand(ZDiscord plugin) {
         this.plugin = plugin;
     }
@@ -100,34 +96,9 @@ public void onSlashCommandInteraction(SlashCommandInteractionEvent event) {
             return;
         }
 
-        var moduleOption = event.getOption("module");
-        var channelOption = event.getOption("channel");
-        if (moduleOption != null && channelOption != null) {
-            String module = moduleOption.getAsString();
-            TextChannel target = channelOption.getAsChannel().asTextChannel();
-            quickSetup(event, module, target);
-            return;
-        }
         showWizardPanel(event);
     }
 
-    @Override
-    public void onCommandAutoCompleteInteraction(CommandAutoCompleteInteractionEvent event) {
-        if (!"setup".equals(event.getName())) {
-            return;
-        }
-        if (!"module".equals(event.getFocusedOption().getName())) {
-            return;
-        }
-        String typed = event.getFocusedOption().getValue().toLowerCase();
-        List<Command.Choice> choices = MODULE_NAMES.stream()
-                .filter(name -> name.startsWith(typed))
-                .map(name -> new Command.Choice(name, name))
-                .limit(25)
-                .collect(Collectors.toList());
-        event.replyChoices(choices).queue();
-    }
-
     private void showWizardPanel(SlashCommandInteractionEvent event) {
         Guild guild = event.getGuild();
         String guildIcon = guild != null && guild.getIconUrl() != null
@@ -225,6 +196,11 @@ private void handleModuleSelect(StringSelectInteractionEvent event) {
             return;
         }
 
+        if ("tickets".equals(module)) {
+            showTicketChannelPrompt(event);
+            return;
+        }
+
         EmbedBuilder prompt = new EmbedBuilder()
                 .setTitle(":gear: Configure " + capitalize(module))
                 .setDescription(info.description
@@ -270,16 +246,16 @@ private void handleChannelSelect(EntitySelectInteractionEvent event) {
         }
         TextChannel channel = (TextChannel) selectedChannel;
 
-        saveToConfig(info.configPath, channel.getId());
-
         switch (module) {
             case "status":
+                saveToConfig(info.configPath, channel.getId());
                 handleStatusSetup(event, channel);
                 return;
             case "tickets":
                 handleTicketSetup(event, channel);
                 return;
             default:
+                saveToConfig(info.configPath, channel.getId());
                 postActivationNotice(channel, info, event.getUser().getName());
                 event.replyEmbeds(EmbedUtil.success(
                         capitalize(module) + " has been linked to " + channel.getAsMention() + ".")
@@ -289,6 +265,29 @@ private void handleChannelSelect(EntitySelectInteractionEvent event) {
         }
     }
 
+    private void showTicketChannelPrompt(StringSelectInteractionEvent event) {
+        EmbedBuilder prompt = new EmbedBuilder()
+                .setTitle(":ticket: Ticket Setup  \u2014  Step 1 of 3")
+                .setDescription("Select the text channel where ZDiscord should post the public ticket panel.\n\n"
+                        + "Private tickets will be created in that channel's category. "
+                        + "If the channel is not inside a category, tickets will be created at the server root.")
+                .setColor(ColorUtil.parseHex("#5865F2"))
+                .setFooter("Step 1/3  \u2022  Select ticket panel channel")
+                .setTimestamp(Instant.now());
+
+        EntitySelectMenu channelMenu = EntitySelectMenu.create(
+                CHANNEL_MENU_PREFIX + "tickets", EntitySelectMenu.SelectTarget.CHANNEL)
+                .setPlaceholder("Select the ticket panel channel")
+                .setMinValues(1)
+                .setMaxValues(1)
+                .build();
+
+        event.replyEmbeds(prompt.build())
+                .addActionRow(channelMenu)
+                .setEphemeral(true)
+                .queue();
+    }
+
     private void handleStatusSetup(EntitySelectInteractionEvent event, TextChannel channel) {
         StatusEmbedBuilder.StatusContext ctx = StatusEmbedBuilder.StatusContext.capture(
                 plugin.getBotManager()::getGuild,
@@ -321,6 +320,8 @@ private void handleTicketSetup(EntitySelectInteractionEvent event, TextChannel c
         saveToConfig("tickets.panel-channel", channel.getId());
         if (channel.getParentCategory() != null) {
             saveToConfig("channels.ticket-category", channel.getParentCategory().getId());
+        } else {
+            saveToConfig("channels.ticket-category", "");
         }
 
         EmbedBuilder rolePrompt = new EmbedBuilder()
@@ -670,7 +671,7 @@ private String supportRoleMention(net.dv8tion.jda.api.events.interaction.Generic
         if (!list.isEmpty()) {
             roleId = list.get(0);
         }
-        if (roleId == null) {
+        if (!TicketModule.isUsableSnowflake(roleId)) {
             return "(unset)";
         }
         Guild guild = event.getGuild();
@@ -772,29 +773,6 @@ private void postTicketPanel(TextChannel channel) {
         plugin.getTicketModule().postPanel(channel);
     }
 
-    private void quickSetup(SlashCommandInteractionEvent event, String module, TextChannel target) {
-        ModuleInfo info = MODULES.get(module);
-        if (info == null) {
-            event.reply("Unknown module: `" + module + "`. Available: "
-                    + String.join(", ", MODULE_NAMES)).setEphemeral(true).queue();
-            return;
-        }
-
-        saveToConfig(info.configPath, target.getId());
-
-        if ("tickets".equals(module) && target.getParentCategory() != null) {
-            saveToConfig("channels.ticket-category", target.getParentCategory().getId());
-            postTicketPanel(target);
-        }
-
-        postActivationNotice(target, info, event.getUser().getName());
-
-        event.replyEmbeds(EmbedUtil.success(
-                capitalize(module) + " linked to " + target.getAsMention() + ".")
-                .build())
-                .setEphemeral(true).queue();
-    }
-
     private void postActivationNotice(TextChannel channel, ModuleInfo info, String username) {
         channel.sendMessageEmbeds(EmbedUtil.simple(
                 info.label + " activated",

src/main/java/dev/demonz/zdiscord/discord/SlashCommandManager.java

@@ -52,12 +52,7 @@ public void registerCommands() {
                 Commands.slash("leaderboard", "View player leaderboards")
                         .addOption(OptionType.STRING, "stat",
                                 "Stat to view (kills, deaths, playtime)", true),
-                Commands.slash("setup", "Open the ZDiscord setup wizard")
-                        .addOption(OptionType.STRING, "module",
-                                "Quick setup: module name (chat, status, events, etc.)",
-                                false, true)
-                        .addOption(OptionType.CHANNEL, "channel",
-                                "Quick setup: target channel", false),
+                Commands.slash("setup", "Open the ZDiscord setup wizard"),
                 Commands.slash("profile", "View a Minecraft player's profile card")
                         .addOption(OptionType.STRING, "player",
                                 "Player name (omit for yourself)", false),

src/main/java/dev/demonz/zdiscord/discord/listeners/TicketButtonListener.java

@@ -5,7 +5,9 @@
 import net.dv8tion.jda.api.Permission;
 import net.dv8tion.jda.api.entities.Member;
 import net.dv8tion.jda.api.entities.Message;
+import net.dv8tion.jda.api.entities.User;
 import net.dv8tion.jda.api.entities.channel.concrete.TextChannel;
+import net.dv8tion.jda.api.interactions.InteractionHook;
 import net.dv8tion.jda.api.events.interaction.component.ButtonInteractionEvent;
 import net.dv8tion.jda.api.events.interaction.component.StringSelectInteractionEvent;
 import net.dv8tion.jda.api.hooks.ListenerAdapter;
@@ -68,9 +70,7 @@ public void onStringSelectInteraction(StringSelectInteractionEvent event) {
             return;
         }
         String categoryId = event.getValues().get(0);
-        plugin.getTicketModule().createTicketForCategory(event.getUser(), categoryId);
-        event.reply("Your support ticket has been created. Check the new channel.")
-                .setEphemeral(true).queue();
+        createTicketFromInteraction(event, event.getUser(), categoryId);
     }
 
     private void handleQuickOpen(ButtonInteractionEvent event) {
@@ -84,9 +84,28 @@ private void handleQuickOpen(ButtonInteractionEvent event) {
                     .setEphemeral(true).queue();
             return;
         }
-        plugin.getTicketModule().createTicketForCategory(event.getUser(), defaultId);
-        event.reply("Your support ticket has been created. Check the new channel.")
-                .setEphemeral(true).queue();
+        createTicketFromInteraction(event, event.getUser(), defaultId);
+    }
+
+    private void createTicketFromInteraction(
+            net.dv8tion.jda.api.events.interaction.GenericInteractionCreateEvent event,
+            User user,
+            String categoryId) {
+        if (event instanceof ButtonInteractionEvent) {
+            ((ButtonInteractionEvent) event).deferReply(true).queue(
+                    hook -> completeTicketCreate(hook, user, categoryId));
+        } else if (event instanceof StringSelectInteractionEvent) {
+            ((StringSelectInteractionEvent) event).deferReply(true).queue(
+                    hook -> completeTicketCreate(hook, user, categoryId));
+        }
+    }
+
+    private void completeTicketCreate(InteractionHook hook, User user, String categoryId) {
+        plugin.getPlatformAdapter().runAsync(() -> {
+            String message = plugin.getTicketModule()
+                    .createTicketForCategory(user, categoryId);
+            hook.sendMessage(message).queue();
+        });
     }
 
     private void handleClose(ButtonInteractionEvent event) {