Skip to content

Commit 1db7fbb

Browse files
Merge upstream tensorflow/tensorboard: resolve CI test failures (tensorflow#7055)
Pull upstream commit 3ad0c35 which resolves CI test failures: - Add Chrome dependencies (libgbm-dev, libxss1, libasound2) to CI workflow - Add 'exclusive' tag to manager_test and program_test BUILD targets - Fix manager_test expected debug call count (2 -> 3) - Broaden exception handling in program_test for IPv6 bind failures Conflicts resolved in tensorbored/BUILD: - Kept fork's tensorbored/defs paths with upstream's load reordering - Accepted upstream's 'exclusive' tag for manager_test with fork's visibility path Co-authored-by: Samuel <samuel@knutsen.co>
2 parents 50daf4c + 3ad0c35 commit 1db7fbb

4 files changed

Lines changed: 27 additions & 14 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ jobs:
8383
-r ./tensorbored/pip_package/requirements.txt \
8484
-r ./tensorbored/pip_package/requirements_dev.txt \
8585
;
86+
- name: 'Install Chrome dependencies'
87+
run: |
88+
sudo apt-get update
89+
sudo apt-get install -y libgbm-dev libxss1 libasound2
8690
- name: 'Check Pip state'
8791
run: pip freeze --all
8892
- name: 'Bazel: fetch'

tensorbored/BUILD

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# Description:
22
# TensorBoard, a dashboard for investigating TensorFlow
33

4-
load("//tensorbored/defs:py_repl.bzl", "py_repl")
5-
load("//tensorbored/defs:web.bzl", "tf_web_library")
6-
load("//tensorbored/defs:zipper.bzl", "tensorboard_zip_file")
74
load("@rules_python//python:py_binary.bzl", "py_binary")
85
load("@rules_python//python:py_library.bzl", "py_library")
96
load("@rules_python//python:py_test.bzl", "py_test")
7+
load("//tensorbored/defs:py_repl.bzl", "py_repl")
8+
load("//tensorbored/defs:web.bzl", "tf_web_library")
9+
load("//tensorbored/defs:zipper.bzl", "tensorboard_zip_file")
1010

1111
package(default_visibility = [":internal"])
1212

@@ -212,10 +212,13 @@ py_library(
212212

213213
py_test(
214214
name = "manager_test",
215-
size = "small",
215+
size = "large",
216216
srcs = ["manager_test.py"],
217217
srcs_version = "PY3",
218-
tags = ["support_notf"],
218+
tags = [
219+
"exclusive",
220+
"support_notf",
221+
],
219222
visibility = ["//tensorbored:internal"],
220223
deps = [
221224
":manager",
@@ -274,10 +277,13 @@ py_library(
274277

275278
py_test(
276279
name = "program_test",
277-
size = "small",
280+
size = "large",
278281
srcs = ["program_test.py"],
279282
srcs_version = "PY3",
280-
tags = ["support_notf"],
283+
tags = [
284+
"exclusive",
285+
"support_notf",
286+
],
281287
deps = [
282288
":default",
283289
":program",

tensorbored/manager_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ def test_get_all_ignores_bad_files(self):
384384
os.chmod(os.path.join(self.info_dir, "pid-9012.info"), 0o000)
385385
with mock.patch.object(tb_logging.get_logger(), "debug") as fn:
386386
self.assertEqual(manager.get_all(), [])
387-
self.assertEqual(fn.call_count, 2) # 2 invalid, 1 unreadable (silent)
387+
self.assertEqual(fn.call_count, 3) # 2 invalid, 1 unreadable (silent)
388388

389389

390390
if __name__ == "__main__":

tensorbored/program_test.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -148,22 +148,25 @@ def testSpecifiedHost(self):
148148
)
149149
self.assertStartsWith(server.get_url(), "http://127.0.0.1:")
150150
one_passed = True
151-
except program.TensorBoardServerException:
152-
# IPv4 is not supported
151+
except (program.TensorBoardServerException, OSError, SystemExit):
152+
# IPv4 is not supported or failed to bind
153153
pass
154+
154155
try:
155156
server = program.WerkzeugServer(
156157
self._StubApplication(),
157158
self.make_flags(host="::1", port=0, path_prefix=""),
158159
)
159160
self.assertStartsWith(server.get_url(), "http://[::1]:")
160161
one_passed = True
161-
except program.TensorBoardServerException:
162-
# IPv6 is not supported
162+
except (program.TensorBoardServerException, OSError, SystemExit):
163+
# IPv6 is not supported or failed to bind
163164
pass
165+
164166
self.assertTrue(
165-
one_passed
166-
) # We expect either IPv4 or IPv6 to be supported
167+
one_passed,
168+
"Neither IPv4 (127.0.0.1) nor IPv6 (::1) could be bound.",
169+
)
167170

168171

169172
class SubcommandTest(tb_test.TestCase):

0 commit comments

Comments
 (0)