Color badge fade display#46
Merged
Merged
Conversation
The color badge/selector column was positioned at the far right of the runs table, requiring horizontal scrolling for runs with long names. Changes: - Make the color column sticky (position: sticky, right: 0) so it always stays visible on the right side of each row - Add opaque background to the color cells so they float above text - Add a ::before pseudo-element with a gradient fade from transparent to the background color, creating a smooth text fade-out effect under the badge - Handle dark mode with matching background colors for both the cell and the gradient - Give the header color cell z-index: 2 so it stays above both the sticky header row and the sticky color content cells Fixes #43 Co-authored-by: Samuel <samuel@knutsen.co>
|
Cursor Agent can help with this pull request. Just |
Closed
Preview Deployment
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Previously, the color badge/selector in the runs data table was positioned as the last column. This meant that for runs with long names, users had to horizontally scroll to view or interact with the color picker, hindering usability.
Technical description of changes
This PR addresses the issue by making the color column sticky on the right side of the runs data table and adding a fade-out effect for the run name text.
Specifically, the following changes were made to
tensorbored/webapp/runs/views/runs_table/runs_data_table.scss:.table-column-colorcells now useposition: sticky; right: 0;to ensure they remain visible on the right edge of the table, regardless of horizontal scroll.::beforepseudo-element is added to each color cell, creating alinear-gradientfromtransparentto the background color over 24px to the left. This provides a smooth fade-out effect for run name text underneath the badge.tb-data-table-header-cell.table-column-color) has itsz-indexset to2to correctly layer at the intersection of the sticky header and sticky column.tb-dark-thememixin.Screenshots of UI changes (or N/A)
N/A - Please verify visually.
Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered (or N/A)
N/A