Url parameter accumulation#47
Merged
Merged
Conversation
Remove legacy Polymer component hash storage for parameters now managed by the Angular app or localStorage: - runSelectionState: now persisted to localStorage via runs_effects.ts - _smoothingWeight: now managed via Angular query param 'smoothing' - tagFilter: now managed via Angular query param 'tagFilter' - regexInput: now managed via Angular query param 'runFilter' These Polymer components were writing state to the URL hash (e.g. #timeseries&runSelectionState=eyJ...) while the Angular routing system preserved the hash on same-route navigations. This caused the URL to accumulate ever-growing parameters that were never cleaned up. The fix: 1. Remove hash storage observers from tf-runs-selector (runSelectionState, regexInput), tf-scalar-dashboard (_smoothingWeight), tf-custom-scalar-dashboard (_smoothingWeight), and tf-tag-filterer (tagFilter). 2. Add cleanup in migrateLegacyURLScheme() to strip these legacy hash params from existing URLs on startup. Fixes: #42 Co-authored-by: Samuel <samuel@knutsen.co>
Remove tf_storage dependency from tf_runs_selector and tf_categorization_utils BUILD files since the import was removed in the previous commit. Co-authored-by: Samuel <samuel@knutsen.co>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: Samuel <samuel@knutsen.co>
Preview Deployment
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains changes generated by a Cursor Cloud Agent