Superimposed plots interaction#48
Merged
Demonstrandum merged 5 commits intoFeb 18, 2026
Merged
Conversation
- Add CSS 'resize: vertical' to chart-container for the grabby corner - Add scalar-card-fob-controller overlay on the line chart for step selection (dotted line) -- reuses existing ScalarCardFobController - Add scalar-card-data-table below the chart showing run values at the selected step -- reuses existing ScalarCardDataTable - Add data-table-container with resize: vertical for the list resize handle - Compute minMaxStep from partitioned series data in the container - Combine global linked time selection with local time selection for the fob controller - Use global single-selection column headers for the data table - Import ScalarCardLineChartModule and ScalarCardDataTableModule in the superimposed card module - Update BUILD deps for card_fob, data_table, and runs types Co-authored-by: Samuel <samuel@knutsen.co>
Co-authored-by: Samuel <samuel@knutsen.co>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: Samuel <samuel@knutsen.co>
This reverts commit ad7c2e3.
Co-authored-by: Samuel <samuel@knutsen.co>
Preview Deployment
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This PR addresses issue #41 by adding the resize grabby corner, step-selection fob, and data table to superimposed plots. This brings their functionality in line with regular scalar cards, allowing users to rescale plots and view detailed run values at a specific step. The core motivation was to enable existing features without duplicating code.
Technical description of changes
superimposed_card_component.scss):resize: verticalto the chart container and a new data table container to enable vertical resizing..superimposed-cardheight to accommodate the data table when present.superimposed_card_component.ng.html):[customChartOverlayTemplate]into the<line-chart>to render the fob controller.<scalar-card-fob-controller>for step selection, reusing the existing component.<scalar-card-data-table>below the chart to display run values, also reusing the existing component.superimposed_card_component.ts):@Inputand@Outputproperties to bindScalarCardFobControllerandScalarCardDataTable.getDataTableColumns,getMinMaxStep,getStepOrLinkedTimeSelection,onDataTableResize) to manage data table visibility, column headers, and time selection.superimposed_card_container.ts):minMaxStep$,stepOrLinkedTimeSelection$, andcolumnHeaders$to provide data to the presentation component.BehaviorSubjectforlocalTimeSelection$to manage per-card step selection.superimposed_card_module.ts):ScalarCardLineChartModule(which exportsScalarCardFobController) andScalarCardDataTableModule.card_fob:types,data_table:types,runs:types,:scalar_card_data_table, and:scalar_card_line_chart.Screenshots of UI changes (or N/A)
N/A
Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered (or N/A)
The task explicitly stated "DO NOT duplicate functionality and code." Therefore, reimplementing the resize handle, fob controller, or data table logic was not considered. The design focused entirely on reusing existing
ScalarCardFobControllerandScalarCardDataTablecomponents.