Fix data table styling and fob dismiss button#50
Merged
Demonstrandum merged 4 commits intoFeb 18, 2026
Conversation
- Move data table and expand button inside .superimposed-card div so they inherit the card's background color, border, and padding - Wire up onStepSelectorToggled in the container to clear the local time selection, so the (x) button on the fob actually dismisses it and hides the data table Co-authored-by: Samuel <samuel@knutsen.co>
cursor
Bot
force-pushed
the
cursor/superimposed-plots-interaction-5d68
branch
from
60c2c83 to
a0bf9ba
Compare
Preview Deployment
Details
|
The (x) button on the fob was resetting to end-of-plot instead of hiding, because clearing localTimeSelection to undefined triggered the fallback that creates a default selection at maxStep. Use null to mean 'user dismissed the fob' (returns undefined to hide it) vs undefined meaning 'not yet interacted, show default'. Co-authored-by: Samuel <samuel@knutsen.co>
Add a generic PersistResizeDirective that uses ResizeObserver to detect when a user resizes an element (via CSS resize: vertical) and stores the height in localStorage under '_tb_resize_heights.v1'. On init, the stored height is restored. Applied to both scalar cards and superimposed cards: - Chart containers keyed by 'scalar-chart:<tag>' / 'superimposed-chart:<id>' - Data table containers keyed by 'scalar-table:<tag>' / 'superimposed-table:<id>' Heights survive page refreshes. Co-authored-by: Samuel <samuel@knutsen.co>
Add explicit type assertion on JSON.parse() to satisfy tsetse rule and strict type checking. Co-authored-by: Samuel <samuel@knutsen.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Technical description of changes
Screenshots of UI changes (or N/A)
Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered (or N/A)