Skip to content

Commit 044185a

Browse files
authored
Merge pull request #128 from DenisValeev/codex/remove-hide/reveal-functionality
2 parents d2dd42d + 691ef43 commit 044185a

2 files changed

Lines changed: 7 additions & 66 deletions

File tree

apps/total-recall/app.js

Lines changed: 3 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
(function () {
22
const notesInput = document.querySelector('[data-notes-input]');
33
const entryEl = document.querySelector('[data-entry-text]');
4-
const placeholderEl = document.querySelector('[data-placeholder]');
54
const counterEl = document.querySelector('[data-counter]');
65
const prevButton = document.querySelector('[data-prev]');
76
const nextButton = document.querySelector('[data-next]');
8-
const revealButton = document.querySelector('[data-reveal]');
97
const shuffleButton = document.querySelector('[data-shuffle]');
108
const saveButton = document.querySelector('[data-save]');
119
const resetButton = document.querySelector('[data-reset]');
@@ -14,11 +12,9 @@
1412
if (
1513
!notesInput ||
1614
!entryEl ||
17-
!placeholderEl ||
1815
!counterEl ||
1916
!prevButton ||
2017
!nextButton ||
21-
!revealButton ||
2218
!shuffleButton ||
2319
!saveButton ||
2420
!resetButton ||
@@ -37,7 +33,6 @@
3733
let entries = [];
3834
let deck = [];
3935
let index = 0;
40-
let isVisible = false;
4136

4237
function setStatus(message) {
4338
statusEl.textContent = message;
@@ -89,26 +84,10 @@
8984
}
9085
}
9186

92-
function setEntryVisible(visible) {
93-
isVisible = visible;
94-
entryEl.classList.toggle('is-visible', visible);
95-
entryEl.setAttribute('aria-hidden', visible ? 'false' : 'true');
96-
placeholderEl.hidden = visible;
97-
revealButton.setAttribute('aria-pressed', visible ? 'true' : 'false');
98-
revealButton.textContent = visible ? 'Hide note' : 'Reveal note';
99-
}
100-
10187
function renderEmptyState() {
10288
counterEl.textContent = '0 of 0';
103-
isVisible = false;
104-
entryEl.textContent = '';
105-
entryEl.classList.remove('is-visible');
106-
entryEl.setAttribute('aria-hidden', 'true');
107-
placeholderEl.hidden = false;
108-
placeholderEl.textContent = 'No notes yet. Add entries below to start reviewing.';
109-
revealButton.disabled = true;
110-
revealButton.setAttribute('aria-pressed', 'false');
111-
revealButton.textContent = 'Reveal note';
89+
entryEl.textContent = 'No notes yet. Add entries below to start reviewing.';
90+
entryEl.classList.add('is-empty');
11291
prevButton.disabled = true;
11392
nextButton.disabled = true;
11493
shuffleButton.disabled = true;
@@ -124,16 +103,12 @@
124103
const current = deck[index];
125104

126105
entryEl.textContent = current;
106+
entryEl.classList.remove('is-empty');
127107
counterEl.textContent = `${index + 1} of ${deck.length}`;
128-
placeholderEl.textContent = 'Ready when you are. Press “Reveal note” or tap space to check your recall.';
129-
130-
revealButton.disabled = false;
131108
const disableNav = deck.length <= 1;
132109
prevButton.disabled = disableNav;
133110
nextButton.disabled = disableNav;
134111
shuffleButton.disabled = deck.length <= 1;
135-
136-
setEntryVisible(false);
137112
}
138113

139114
function showNext() {
@@ -154,13 +129,6 @@
154129
render();
155130
}
156131

157-
function toggleEntry() {
158-
if (!entries.length) {
159-
return;
160-
}
161-
setEntryVisible(!isVisible);
162-
}
163-
164132
function reshuffleDeck() {
165133
if (entries.length <= 1) {
166134
return;
@@ -203,7 +171,6 @@
203171

204172
prevButton.addEventListener('click', showPrev);
205173
nextButton.addEventListener('click', showNext);
206-
revealButton.addEventListener('click', toggleEntry);
207174
shuffleButton.addEventListener('click', reshuffleDeck);
208175
saveButton.addEventListener('click', handleSave);
209176
resetButton.addEventListener('click', handleReset);
@@ -219,21 +186,6 @@
219186
} else if (event.key === 'ArrowLeft') {
220187
event.preventDefault();
221188
showPrev();
222-
} else if (event.key === ' ' || event.key === 'Spacebar') {
223-
const active = document.activeElement;
224-
if (
225-
active &&
226-
(active.tagName === 'BUTTON' ||
227-
active.tagName === 'TEXTAREA' ||
228-
active.tagName === 'INPUT' ||
229-
active.tagName === 'A' ||
230-
active.tagName === 'SUMMARY' ||
231-
active.tagName === 'SELECT')
232-
) {
233-
return;
234-
}
235-
event.preventDefault();
236-
toggleEntry();
237189
}
238190
});
239191

apps/total-recall/index.html

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -160,23 +160,16 @@
160160
min-height: 180px;
161161
}
162162

163-
.card__placeholder {
164-
margin: 0;
165-
color: var(--text-secondary);
166-
font-size: clamp(1rem, 1.4vw + 0.85rem, 1.2rem);
167-
line-height: 1.6;
168-
}
169-
170163
.card__text {
171164
margin: 0;
172165
font-size: clamp(1.25rem, 2.2vw + 1rem, 2.05rem);
173166
line-height: 1.55;
174167
white-space: pre-line;
175-
display: none;
176168
}
177169

178-
.card__text.is-visible {
179-
display: block;
170+
.card__text.is-empty {
171+
color: var(--text-secondary);
172+
font-size: clamp(1rem, 1.4vw + 0.85rem, 1.2rem);
180173
}
181174

182175
.controls {
@@ -382,17 +375,13 @@ <h1>Total Recall</h1>
382375
<span id="card-counter" data-counter>0 of 0</span>
383376
</div>
384377
<div class="card__body">
385-
<p id="entry-placeholder" class="card__placeholder" data-placeholder>Add notes below to get started.</p>
386-
<p id="entry-text" class="card__text" data-entry-text aria-hidden="true"></p>
378+
<p id="entry-text" class="card__text is-empty" data-entry-text>Add notes below to get started.</p>
387379
</div>
388380
</article>
389381
<div class="controls" role="group" aria-label="Deck controls">
390382
<button class="control-button control-button--secondary" type="button" data-prev>
391383
Previous
392384
</button>
393-
<button class="control-button control-button--primary" type="button" data-reveal aria-pressed="false">
394-
Reveal note
395-
</button>
396385
<button class="control-button control-button--secondary" type="button" data-next>
397386
Next
398387
</button>

0 commit comments

Comments
 (0)