Skip to content

Commit b4eaf02

Browse files
authored
Merge pull request #132 from DenisValeev/codex/update-card-display-in-total-recall
Simplify Total Recall deck layout
2 parents 81c48e0 + db29d25 commit b4eaf02

2 files changed

Lines changed: 2 additions & 39 deletions

File tree

apps/total-recall/app.js

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
(function () {
22
const notesInput = document.querySelector('[data-notes-input]');
33
const currentEntryEl = document.querySelector('[data-current-text]');
4-
const previewEntryEl = document.querySelector('[data-preview-text]');
5-
const previewCard = document.querySelector('[data-preview-card]');
64
const counterEl = document.querySelector('[data-counter]');
75
const prevButton = document.querySelector('[data-prev]');
86
const nextButton = document.querySelector('[data-next]');
@@ -14,8 +12,6 @@
1412
if (
1513
!notesInput ||
1614
!currentEntryEl ||
17-
!previewEntryEl ||
18-
!previewCard ||
1915
!counterEl ||
2016
!prevButton ||
2117
!nextButton ||
@@ -34,7 +30,6 @@
3430
"I told my computer I needed a break, and it said 'No problem — I'll go to sleep.'",
3531
'Why did the scarecrow get a promotion? He was outstanding in his field.'
3632
].join('\n\n');
37-
const PREVIEW_PLACEHOLDER = 'Add another note to preview the upcoming card.';
3833

3934
let entries = [];
4035
let deckOrder = [];
@@ -184,9 +179,6 @@
184179
counterEl.textContent = '0 of 0';
185180
currentEntryEl.textContent = 'No notes yet. Add entries below to start reviewing.';
186181
currentEntryEl.classList.add('is-empty');
187-
previewEntryEl.textContent = PREVIEW_PLACEHOLDER;
188-
previewEntryEl.classList.add('is-empty');
189-
previewCard.setAttribute('aria-hidden', 'true');
190182
prevButton.disabled = true;
191183
nextButton.disabled = true;
192184
shuffleButton.disabled = true;
@@ -216,17 +208,6 @@
216208
nextButton.disabled = disableNav;
217209
shuffleButton.disabled = deckOrder.length <= 1;
218210

219-
if (deckOrder.length > 1) {
220-
const previewEntryIndex = deckOrder[(index + 1) % deckOrder.length];
221-
const preview = entries[previewEntryIndex];
222-
previewEntryEl.textContent = preview;
223-
previewEntryEl.classList.remove('is-empty');
224-
previewCard.removeAttribute('aria-hidden');
225-
} else {
226-
previewEntryEl.textContent = PREVIEW_PLACEHOLDER;
227-
previewEntryEl.classList.add('is-empty');
228-
previewCard.setAttribute('aria-hidden', 'true');
229-
}
230211
}
231212

232213
function showNext() {

apps/total-recall/index.html

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,12 @@
133133

134134
.card__meta {
135135
display: flex;
136-
justify-content: space-between;
137136
align-items: center;
138137
color: var(--text-secondary);
139138
font-weight: 600;
140139
letter-spacing: 0.04em;
141140
text-transform: uppercase;
142-
font-size: 0.85rem;
141+
font-size: 0.8rem;
143142
}
144143

145144
.card__body {
@@ -151,7 +150,7 @@
151150

152151
.card__text {
153152
margin: 0;
154-
font-size: clamp(1.1rem, 1.8vw + 0.95rem, 1.7rem);
153+
font-size: clamp(1rem, 1.4vw + 0.85rem, 1.4rem);
155154
line-height: 1.5;
156155
white-space: pre-line;
157156
}
@@ -161,14 +160,6 @@
161160
font-size: clamp(0.95rem, 1.2vw + 0.85rem, 1.1rem);
162161
}
163162

164-
.card--preview {
165-
opacity: 0.92;
166-
}
167-
168-
.card--preview[aria-hidden="true"] {
169-
opacity: 0.6;
170-
}
171-
172163
.controls {
173164
display: flex;
174165
flex-wrap: wrap;
@@ -370,20 +361,11 @@
370361
<article class="card card--current">
371362
<div class="card__meta">
372363
<span id="card-counter" data-counter>0 of 0</span>
373-
<span>Now playing</span>
374364
</div>
375365
<div class="card__body">
376366
<p id="entry-text" class="card__text is-empty" data-current-text>Add notes below to get started.</p>
377367
</div>
378368
</article>
379-
<article class="card card--preview" data-preview-card aria-label="Next card">
380-
<div class="card__meta">
381-
<span>Next up</span>
382-
</div>
383-
<div class="card__body">
384-
<p class="card__text is-empty" data-preview-text>Add another note to preview the upcoming card.</p>
385-
</div>
386-
</article>
387369
</section>
388370
<div class="controls" role="group" aria-label="Deck controls">
389371
<button class="control-button control-button--secondary" type="button" data-prev>

0 commit comments

Comments
 (0)