fix: clean up code comments, remove dead code, add missing type annotations

Author: bifferz

Core.lua

@@ -206,7 +206,7 @@ function Core:OnEnable()
         -- or if equipment is nil (tool item was uncached so slot group was skipped entirely)
         if cp.equipment == nil then
           needsRescan = true
-        elseif cp.equipment ~= nil then
+        else
           for i = 1, 3 do
             if cp.equipment[i] and cp.equipment[i].pending then
               needsRescan = true

Data.lua

@@ -356,10 +356,6 @@ function Data:MigrateDB()
         end
       end
     end
-    if self.db.global.DBVersion == 19 then
-      -- No transform needed: new equipment/profGearScore fields default to nil (never scanned),
-      -- which is correct -- existing characters will be rescanned on next login.
-    end
     self.db.global.DBVersion = self.db.global.DBVersion + 1
     self:MigrateDB()
   end
@@ -480,7 +476,7 @@ function Data:ScanProfessionEquipment()
   local professionIndex1, professionIndex2 = GetProfessions()
   local professionIndexes = { professionIndex1, professionIndex2 }
 
-  for slotGroup, group in ipairs(PROF_SLOT_GROUPS) do
+  for _, group in ipairs(PROF_SLOT_GROUPS) do
     -- Determine which profession owns this slot group by matching the tool slot item's
     -- subType (e.g. "Enchanting") against GetProfessionInfo name (position 1).
     -- GetProfessions() ordering does not reliably map to PROF0/PROF1 slot ordering.

Interface.lua

@@ -273,11 +273,9 @@ function UI:CreateTableFrame(config)
 
             local iconSize = iconData.size or 18
             iconFrame:SetSize(iconSize, iconSize)
-            -- Quality star atlas is 30x34; render at 14x14 (slight crop accepted)
             iconFrame.overlay:SetSize(14, 14)
             iconFrame.overlay:ClearAllPoints()
             iconFrame.overlay:SetPoint("BOTTOMRIGHT", iconFrame, "BOTTOMRIGHT", 2, -2)
-            -- Callers must always provide iconFileID; nil renders as a blank frame (acceptable for empty slots using EMPTY_SLOT_TEXTURE).
             iconFrame.texture:SetTexture(iconData.iconFileID)
             if iconData.unscanned then
               iconFrame.texture:SetVertexColor(0.4, 0.4, 0.4, 1)  -- dim unscanned slots

Main.lua

@@ -91,7 +91,7 @@ local function GearCellIcons(characterProfession, skillLineVariantID)
       }
     else
       -- Scanned empty, wrong expansion gear, or item data still loading
-      local isEmpty = slot == nil or (slot and not slot.pending and not slotBelongs)
+      local isEmpty = slot == nil or (slot and not slot.pending and expansionID ~= nil and not slotBelongs)
       icons[i] = {
         iconFileID = EMPTY_SLOT_TEXTURE,
         onEnter    = function(frame)

Types.lua

@@ -90,12 +90,14 @@
 ---@field completed boolean Whether the first craft has been completed
 
 ---@class WK_ProfessionGearSlot
----@field itemLink string        -- Full WoW item link
----@field itemQuality integer    -- 2=Uncommon, 3=Rare, 4=Epic
----@field itemLevel integer      -- Item level
----@field iconFileID integer     -- Texture fileID for the item icon
----@field score integer          -- 0-15 computed score for this slot
----@field craftingRank integer   -- 1-5 rank within tier (stored to avoid recalculation at render)
+---@field itemLink string          -- Full WoW item link
+---@field itemQuality integer      -- 2=Uncommon, 3=Rare, 4=Epic
+---@field itemLevel integer        -- Item level
+---@field iconFileID integer       -- Texture fileID for the item icon
+---@field score integer            -- 0-15 computed score for this slot
+---@field craftingRank integer     -- 1-5 rank within tier (stored to avoid recalculation at render)
+---@field itemExpansionID integer? -- Expansion that owns this item (position 15 from C_Item.GetItemInfo)
+---@field pending boolean?         -- true = item data not yet in cache; slot will be rescanned on GET_ITEM_INFO_RECEIVED
 
 ---@class WK_CharacterProfession
 ---@field enabled boolean