fix(socket): release lock on client disconnect to prevent deadlock#55
Open
tolgakaratas wants to merge 3 commits into
Open
fix(socket): release lock on client disconnect to prevent deadlock#55tolgakaratas wants to merge 3 commits into
tolgakaratas wants to merge 3 commits into
Conversation
- Update jsoup to 1.17.2 to fix multiple security vulnerabilities - Update HtmlTools.java NodeTraversor API usage for jsoup 1.17 compatibility - Also fix Makefile audit to scan build/ directory only (was reverted) Fixes: GHSA-m72m-mhq2-9p6c, GHSA-gp7f-rwcx-9369
- Follows least privilege principle per Scorecard Token-Permissions check - Sets default read-only for all jobs, with write permissions only at job level - Resolves Code Scanning alert #244
- Add unlock() call in terminateSocket() to release lock when client disconnects - Add null check for controller before unlocking - Add exception handling for IllegalStateException, IllegalArgumentException, NullPointerException - Add fine-level logging for debugging Fixes CWE-833 (Lock Not Released) vulnerability alert
github-actions
Bot
added
ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ServerCommunication.terminateSocket()- now callsunlock()before closing socketVerification
Related Alerts