Skip to content

Fix: Always return HTTP 200 to display error cards in README (#860) #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DenverCoder1 merged 3 commits into from
Feb 5, 2026
Merged

Fix: Always return HTTP 200 to display error cards in README (#860) #871

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cce131b
working to fix the error
victorjudysen Jan 30, 2026
48f766f
working to fix the error
victorjudysen Jan 30, 2026
a1f9072
Delete composer-setup.php
DenverCoder1 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/card.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,9 +804,10 @@ function convertSvgToPng(string $svg, int $cardWidth, int $cardHeight): string
*
* @param string|array $output The stats (array) or error message (string) to display
* @param array<string,string>|NULL $params Request parameters
* @param int $errorCode The HTTP error code (used for JSON responses)
* @return array The Content-Type header and the response body, and status code in case of an error
*/
function generateOutput(string|array $output, array $params = null): array
function generateOutput(string|array $output, array $params = null, int $errorCode = 200): array
{
$params = $params ?? $_REQUEST;

Expand All @@ -815,7 +816,7 @@ function generateOutput(string|array $output, array $params = null): array
// output JSON data
if ($requestedType === "json") {
// generate array from output
$data = gettype($output) === "string" ? ["error" => $output] : $output;
$data = gettype($output) === "string" ? ["error" => $output, "code" => $errorCode] : $output;
return [
"contentType" => "application/json",
"body" => json_encode($data),
Expand Down Expand Up @@ -864,13 +865,15 @@ function generateOutput(string|array $output, array $params = null): array
* Set headers and output response
*
* @param string|array $output The Content-Type header and the response body
* @param int $responseCode The HTTP response code to send
* @param int $responseCode The HTTP response code to send (stored for JSON consumers but always returns 200 for images)
* @return void The function exits after sending the response
*/
function renderOutput(string|array $output, int $responseCode = 200): void
{
$response = generateOutput($output);
http_response_code($response["status"] ?? $responseCode);
$response = generateOutput($output, null, $responseCode);
// Always return HTTP 200 for SVG/PNG so GitHub's image proxy (Camo) displays error cards
// instead of broken images. The original error code is included in JSON responses.
http_response_code(200);
header("Content-Type: {$response["contentType"]}");
exit($response["body"]);
}