Add random color generation for RendererModel#432
Open
hnpct wants to merge 1 commit into
Open
Conversation
DenverCoder1
requested changes
Jun 1, 2026
Comment on lines
+6
to
+13
| function getRandomColor() { | ||
| var letters = '0123456789ABCDEF'; | ||
| var color = '#'; | ||
| for (var i = 0; i < 6; i++) { | ||
| color += letters[Math.floor(Math.random() * 16)]; | ||
| } | ||
| return color; | ||
| } |
Owner
There was a problem hiding this comment.
Firstly, this is JavaScript code in a server-side PHP file. If this is intended to target the demo site, this change should be implemented in /src/demo/js/script.js instead of here.
Regarding the function, as this simply picks random hex characters it does not differentiate between good and ugly colors, dark and light colors. I think it would better to pick a list of different nice looking hues along a similar brightness and saturation to randomly choose from so that all the random colors look good and are readable on all backgrounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
How Has This Been Tested?
composer test