Merge pull request #238 from Deodat-Lawson/feature/predictive-document-analysis-improvement

fix test

Author: Deodat-Lawson

src/app/api/agents/predictive-document-analysis/services/analysisEngine.ts

@@ -162,7 +162,7 @@ function createAnalysisPrompt(
 
         If there are no notable insights, return an empty insights array.
 
-        ${guidanceByType[specification.type] || guidanceByType.general}
+        ${guidanceByType[specification.type] ?? guidanceByType.general}
 
         ${analysisInstructions}
 
@@ -429,12 +429,12 @@ export async function analyzeDocumentChunks(
         ]);
 
         const llmInsights: DocumentInsight[] = chunkResults.flatMap(
-            result => (result.insights ?? []) as DocumentInsight[],
+            result => result.insights ?? [],
         );
 
         const combinedResult: PredictiveAnalysisResult = {
-            missingDocuments: chunkResults.flatMap(result => result.missingDocuments || []),
-            recommendations: chunkResults.flatMap(result => result.recommendations || []),
+            missingDocuments: chunkResults.flatMap(result => result.missingDocuments ?? []),
+            recommendations: chunkResults.flatMap(result => result.recommendations ?? []),
         };
 
         combinedResult.missingDocuments = filterNonFindingDocuments(combinedResult.missingDocuments);
@@ -772,13 +772,13 @@ function promoteStrongRecommendations(
         const matchesPhrase = PROMOTION_PHRASES.some(p => lower.includes(p));
         if (!matchesPhrase) continue;
 
-        const nameMatch = rec.match(NAMED_DOC_PATTERN);
+        const nameMatch = NAMED_DOC_PATTERN.exec(rec);
         const docName = (nameMatch?.[1] ?? nameMatch?.[2] ?? '').trim();
         if (!docName || docName.length < 3) continue;
 
         if (existingNames.has(docName.toLowerCase())) continue;
 
-        const pageMatch = rec.match(PAGE_PATTERN);
+        const pageMatch = PAGE_PATTERN.exec(rec);
         const page = pageMatch ? parseInt(pageMatch[1]!, 10) : 1;
 
         promoted.push({

src/app/api/agents/predictive-document-analysis/utils/insightExtractors.ts

@@ -41,7 +41,7 @@ function extractSurroundingSentence(text: string, matchIndex: number, matchLengt
 
     let end = matchIndex + matchLength;
     const searchForward = text.slice(end, end + 300);
-    const fwdMatch = searchForward.match(sentenceBreak);
+    const fwdMatch = sentenceBreak.exec(searchForward);
     if (fwdMatch?.index !== undefined) {
         end = end + fwdMatch.index + fwdMatch[0].length;
     } else {
@@ -305,7 +305,7 @@ function buildResourceTitle(url: string, context: string, hostname: string): str
         return `Watch: Video on ${hostname.replace(/^www\./, '')}`;
     }
 
-    const actionMatch = context.match(RESOURCE_ACTION_RE);
+    const actionMatch = RESOURCE_ACTION_RE.exec(context);
     if (actionMatch) {
         const afterAction = context.slice((actionMatch.index ?? 0) + actionMatch[0].length).trim();
         const clean = afterAction.replace(/https?:\/\/[^\s]+/g, '').trim();

src/app/employer/documents/components/DocumentSanityChecker.tsx

@@ -203,6 +203,7 @@ function LinkCard({ doc }: { doc: MissingDocument }) {
       )}
     >
       {faviconDomain ? (
+        /* eslint-disable-next-line @next/next/no-img-element */
         <img
           src={`https://www.google.com/s2/favicons?sz=32&domain=${faviconDomain}`}
           alt=""
@@ -331,6 +332,7 @@ function InsightCard({
               className="flex items-center gap-1.5 px-2.5 py-1.5 rounded-lg text-[11px] font-semibold text-blue-600 dark:text-blue-400 bg-blue-50 dark:bg-blue-900/20 hover:bg-blue-100 dark:hover:bg-blue-900/30 transition-all duration-150"
             >
               {faviconHost ? (
+                /* eslint-disable-next-line @next/next/no-img-element */
                 <img
                   src={`https://www.google.com/s2/favicons?sz=32&domain=${faviconHost}`}
                   alt=""
@@ -383,7 +385,10 @@ export function DocumentSanityChecker({
     return pages.size > 1;
   }, [issues]);
 
-  const insights = predictiveAnalysis?.analysis.insights ?? [];
+  const insights = useMemo(
+    () => predictiveAnalysis?.analysis.insights ?? [],
+    [predictiveAnalysis?.analysis.insights],
+  );
   const recommendations = predictiveAnalysis?.analysis.recommendations ?? [];
   const resolved = predictiveAnalysis?.analysis.resolvedDocuments ?? [];
   const webRefs = predictiveAnalysis?.analysis.suggestedRelatedDocuments ?? [];