Extending length of PURL and PURLCOORDINATES columns from 786 to 4096#6138
Closed
mrgxqq wants to merge 2 commits into
Closed
Extending length of PURL and PURLCOORDINATES columns from 786 to 4096#6138mrgxqq wants to merge 2 commits into
mrgxqq wants to merge 2 commits into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Signed-off-by: mrgxqq <i.starmax99@gmail.com>
5978e60 to
d67d718
Compare
Signed-off-by: mrgxqq <i.starmax99@gmail.com>
Member
|
Thanks for the PR, but this will break for MSSQL, as mentioned in the PR you linked. The problem is that this column is indexed, and some RDBMSes cannot deal with indexes on columns that large. |
Author
|
Thank you for the explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increased the maximum length of the
PURLandPURLCOORDINATESfields.In some BOM files generated on Windows environments, the
PURLvalue can become excessively long — in certain cases exceeding the current limit of 786 characters. As a result, importing such BOM files into DependencyTrack fails with the following error:This fix increases the allowed field length and resolves the issue when importing such BOM files.
A similar issue has also been discussed previously in
#3560.Addressed Issue
fixes #3560
Additional Details
The issue was reproducible with BOM files generated on Windows, where the path contained in the
PURLbecame significantly longer than expected.Due to the length limitation of the
PURLCOORDINATESdatabase field, the database rejected the record during BOM import.This change is limited to increasing the allowed data size and does not affect the existing PURL processing logic.
Checklist