Skip to content

Include analysis.detail in DefectDojo finding payload#6181

Merged
nscuro merged 11 commits into
DependencyTrack:4.14.xfrom
webdevred:forward-analysis-detail-to-defectdojo
Jun 23, 2026
Merged

Include analysis.detail in DefectDojo finding payload#6181
nscuro merged 11 commits into
DependencyTrack:4.14.xfrom
webdevred:forward-analysis-detail-to-defectdojo

Conversation

@webdevred

@webdevred webdevred commented May 28, 2026

Copy link
Copy Markdown
Contributor

Description

When DefectDojo is used as the primary triage surface and Dependency-Track as the SBOM ingestion engine, the per-finding audit text stored in analysis.detail never made it into the payload sent to DefectDojo. Auditors working in DefectDojo had no way to see that context without switching back to DT for every finding.

This adds ANALYSIS."DETAILS" to the SQL queries that back the Finding model, which makes the field flow into the Finding Packaging Format document that the DefectDojo integration uploads. The field appears as analysis.detail alongside the existing analysis.state and analysis.isSuppressed fields.

One option considered was prepending the audit detail directly to vulnerability.description in the FPF, which would have made it visible in DefectDojo without any changes on that side. That was rejected because vulnerability.description is CVE data and mixing analyst notes into it would affect any other consumer of the FPF. Adding it as a separate field keeps the concerns separated and lets each consumer decide how to present it. A companion PR to DefectDojo appends it to the finding description there.

One pre-existing bug is also fixed here: after the new column was inserted at position 36, the QUERY_ALL_FINDINGS call site in FindingsSearchQueryManager was reading the project UUID from the wrong index. This would have caused a runtime failure in the global findings view for any project with a finding that has audit detail set.

image image

Related to DefectDojo/django-DefectDojo#14931

Addressed issue

Closes #6169

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@owasp-dt-bot

owasp-dt-bot commented May 28, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production

codacy-production Bot commented May 28, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@nscuro

nscuro commented May 29, 2026

Copy link
Copy Markdown
Member

Hi @webdevred, please re-target your PR at either 4.14.x (for v4) or main (for v5) as per https://github.com/DependencyTrack/dependency-track/blob/main/V5_MIGRATION.md#contributors-and-pr-authors.

webdevred added 6 commits May 31, 2026 00:07
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
…S column shift

Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
…LL_FINDINGS

Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
@webdevred
webdevred changed the base branch from master to 4.14.x May 31, 2026 15:33
@webdevred
webdevred force-pushed the forward-analysis-detail-to-defectdojo branch from e9e8bfb to 70c2170 Compare May 31, 2026 15:43
@webdevred webdevred mentioned this pull request May 31, 2026
5 tasks
Comment thread src/main/java/org/dependencytrack/model/Finding.java
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
@webdevred
webdevred requested a review from nscuro June 22, 2026 10:37
@nscuro nscuro added this to the 4.14.3 milestone Jun 22, 2026
@nscuro nscuro added the enhancement New feature or request label Jun 22, 2026
Signed-off-by: webdevred <148627186+webdevred@users.noreply.github.com>
@webdevred
webdevred force-pushed the forward-analysis-detail-to-defectdojo branch from 3054bf6 to 09ea5d5 Compare June 22, 2026 18:42
@nscuro nscuro added the integration/defectdojo Related to the Defect Dojo integration label Jun 23, 2026
@nscuro
nscuro merged commit 3975e95 into DependencyTrack:4.14.x Jun 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request integration/defectdojo Related to the Defect Dojo integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants