Rename container image and add tag policy#2138
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage ∅ diff coverage · -0.08% coverage variation
Metric Results Coverage variation ✅ -0.08% coverage variation (-1.00%) Diff coverage ✅ ∅ diff coverage (70.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (dadd486) 41636 35833 86.06% Head commit (ce28898) 41636 (+0) 35799 (-34) 85.98% (-0.08%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#2138) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s container image naming and publishing/tagging strategy to align with Dependency-Track’s v5+ lifecycle and avoid conflicts with v4, including removing the latest tag and switching snapshot tagging to <major>-snapshot.
Changes:
- Renamed the container image from
ghcr.io/dependencytrack/hyades-apiservertoghcr.io/dependencytrack/apiserveracross build tooling, docs, dev compose, and tests. - Updated CI to derive versions from the Maven POM and to publish release tags as
:<major>.<minor>.<patch>,:<major>.<minor>, and:<major>(nolatest). - Updated CI build workflow to publish snapshots as
<major>-snapshotand added tag/ref validation in the reusable workflow.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Updates local build image tag to the new apiserver image name. |
| e2e/src/test/java/org/dependencytrack/e2e/AbstractE2ET.java | Points e2e tests at the renamed apiserver GHCR image. |
| DEVELOPING.md | Updates developer documentation to reference the new local image name. |
| dev/compose.yaml | Switches dev compose image name and default tag to apiserver:5-snapshot. |
| apiserver/src/test/java/org/dependencytrack/TestDatabaseManager.java | Renames the testcontainer lock file to match the new service/image naming. |
| apiserver/src/test/java/org/dependencytrack/PostgresTestContainer.java | Updates the testcontainer label owner value from hyades-apiserver to apiserver. |
| .idea/runConfigurations/Build_Image.xml | Updates IntelliJ run configuration image tag to the renamed image. |
| .github/workflows/ci-publish.yaml | Uses Maven to parse project version (requires JDK setup) for release builds. |
| .github/workflows/ci-build.yaml | Derives <major>-snapshot automatically from POM and adds manual override input. |
| .github/workflows/_meta-build.yaml | Renames published image and implements the new tag policy + validation. |
Files not reviewed (1)
- .idea/runConfigurations/Build_Image.xml: Language not supported
d28683d to
e333383
Compare
|
Docker Hub credentials have been updated to a token that has push permissions for both |
|
The |
Implements DependencyTrack/dependency-track#6103 by: 1. Renaming the container image from `hyades-apiserver` to `apiserver`. 2. Publishing snapshot versions as `<major>-snapshot` instead of `snapshot` to avoid conflicts with v4. * For release builds, publishing `:<major>.<minor>.<patch>` tags. `latest` is no longer published. Signed-off-by: nscuro <nscuro@protonmail.com>
Description
Implements DependencyTrack/dependency-track#6103 by:
hyades-apiservertoapiserver.<major>-snapshotinstead ofsnapshotto avoid conflicts with v4.:<major>.<minor>.<patch>,:<major>.<minor>, and:<major>tags.latestis no longer published.Addressed Issue
Closes DependencyTrack/dependency-track#6103
Additional Details
N/A
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/