Fixed some more compiler warnings

These showed up after a clean rebuild, mostly complaining about
documentation comments not matching the function signature.

Author: etremel

include/cascade/cascade_interface.hpp

@@ -49,8 +49,6 @@ class CriticalDataPathObserver : public derecho::DeserializationContext {
      * @param[in]   value             The value of the K/V pair
      * @param[in]   cascade_ctxt      The cascade context to be used later
      * @param[in]   is_trigger        True for critical data path of `p2p_send`; otherwise, the critical data path of `ordered_send`.
-     *
-     * @return void
      */
     virtual void operator()(const uint32_t subgroup_idx,
                             const uint32_t shard_idx,
@@ -111,8 +109,6 @@ class ICascadeStore {
      *
      * @param[in]   value   The K/V pair value
      * @param[in]   as_trigger  The object will NOT be used to update the K/V state.
-     *
-     * @return      void
      */
     virtual void put_and_forget(const VT& value, bool as_trigger) const = 0;
 
@@ -149,7 +145,7 @@ class ICascadeStore {
      *              If `stable == false`, we only return the data reflecting the latest locally delivered atomic
      *              broadcast. Otherwise, stable data will be returned, meaning that the persisted states returned
      *              is safe: they will survive after whole system recovery.
-     * @param[in]   exact 
+     * @param[in]   exact
      *              The exact match flag: this function try to return the value of that key at the 'ver'. If such a
      *              value does not exists and exact is true, it will throw an exception. If such a value does not
      *              exists and exact is false, it will return the latest state of the value for 'key' before 'ver'.
@@ -272,7 +268,7 @@ class ICascadeStore {
      * @param[in]   key     The key
      * @param[in]   ver     Version, if `ver == CURRENT_VERSION`, get the latest value.
      * @param[in]   stable
-     * @param[in]   exact 
+     * @param[in]   exact
      *              The exact match flag: this function try to return the value of that key at the 'ver'. If such a
      *              value does not exists and exact is true, it will throw an exception. If such a value does not
      *              exists and exact is false, it will return the latest state of the value for 'key' before 'ver'.
@@ -427,7 +423,7 @@ VT create_null_object_cb(const KT& key = *IK);
  * We use both the concepts of null and valid object in Cascade. A null object precisely means 'no data'; while a
  * valid object literarily means an object is 'valid'. Technically, a null object has a valid key while invalid
  * object does not.
- * 
+ *
  * @tparam      KT      The key type.
  * @tparam      VT      The value type.
  */
@@ -489,7 +485,7 @@ class IKeepVersion {
 
     /**
      * @brief   The version getter
-     * 
+     *
      * Get the version
      *
      * @return  The K/V object's version.

include/cascade/detail/prefix_registry.hpp

@@ -115,8 +115,6 @@ class PrefixRegistry {
      *
      * @param path      - the full path.
      * @param collector - the lambda function to collect values for all prefixes of a string.
-     *
-     * @return 
      */
     void collect_values_for_prefixes(const std::string& path,
             const std::function<void(const std::string& prefix,const std::shared_ptr<T>& value)>& collector) const;

include/cascade/service.hpp

@@ -863,8 +863,6 @@ namespace cascade {
          * @param[in] object            the object to write.
          * @param[in] subgroup_index    the subgroup index of CascadeType
          * @param[in] nodes_and_futures map from node ids to futures.
-         *
-         * @return an array of void futures, which length is nodes.size()
          */
         template <typename SubgroupType>
         void collective_trigger_put(const typename SubgroupType::ObjectType& object,

include/cascade/utils.hpp

@@ -85,7 +85,6 @@ class OpenLoopLatencyCollectorClient {
      * @param id        The event id for corresponding event.
      * @param use_local_ts  Using loca timestamp.
      *
-     * @return          N/A
      */
     virtual void ack(uint32_t type, uint32_t id, bool use_local_ts = false) = 0;
 

src/applications/tests/cascade_as_subgroup_classes/cli_example.cpp

@@ -32,7 +32,7 @@ static std::vector<std::string> tokenize(std::string& line) {
 }
 
 static void client_help() {
-    static const char* HELP_STR = 
+    static const char* HELP_STR =
         "(v/p/t)put <object_id> <contents>\n"
         "    - Put an object\n"
         "(v/p)get <object_id> [-t timestamp_in_us | -v version_number]\n"
@@ -67,7 +67,7 @@ static void client_put(derecho::ExternalGroupClient<VCS,PCS,TCS>& group,
     }
 
     uint64_t key = std::stoll(tokens[1]);
-    
+
     //TODO: the previous_version should be used to enforce version check. INVALID_VERSION disables the feature.
     ObjectWithUInt64Key o(key,Blob(reinterpret_cast<const uint8_t*>(tokens[2].c_str()),tokens[2].size()));
 
@@ -95,7 +95,7 @@ static void client_trigger_put(derecho::ExternalGroupClient<VCS,PCS,TCS>& group,
     }
 
     uint64_t key = std::stoll(tokens[1]);
-    
+
     ObjectWithUInt64Key o(key,Blob(reinterpret_cast<const uint8_t*>(tokens[2].c_str()),tokens[2].size()));
 
     ExternalClientCaller<TCS,std::remove_reference<decltype(group)>::type>& vcs_ec = group.get_subgroup_caller<TCS>();
@@ -203,7 +203,7 @@ static void client_remove(derecho::ExternalGroupClient<VCS,PCS,TCS>& group,
     }
 
     uint64_t key = std::stoll(tokens[1]);
-    
+
     if (is_persistent) {
         ExternalClientCaller<PCS,std::remove_reference<decltype(group)>::type>& pcs_ec = group.get_subgroup_caller<PCS>();
         auto result = pcs_ec.p2p_send<RPC_NAME(remove)>(member,key);
@@ -300,6 +300,7 @@ class PerfCDPO : public CriticalDataPathObserver<CascadeType> {
     // @overload
     void operator () (const uint32_t sgidx,
                       const uint32_t shidx,
+                      const derecho::node_id_t sender_id,
                       const typename CascadeType::KeyType& key,
                       const typename CascadeType::ObjectType& value,
                       ICascadeContext* cascade_context,

src/udl_zoo/mproc/object_commit_protocol.hpp

@@ -42,7 +42,7 @@ class ObjectCommitRequestHeader {
     /**
      * @brief The version assigned to this put operation.
      */
-    version_t       version;
+    persistent::version_t version;
     /**
      * @brief Control flags for the request
      * - `flags & OBJECT_COMMIT_REQUEST_MEMORY_MASK` tells memory type: inline or shared memory