Skip to content

Commit e2821f8

Browse files
committed
Improved documentation in service.hpp, fixed compiler warnings
The comments on the main API functions in service.hpp were missing some details and were sometimes out-of-date with respect to the code. Also, a newer g++ (version 13.3) emitted some warnings about existing code that needed to be updated (e.g. to remove unnecessary std::moves). Finally, the string constants in service.hpp should be declared as constexpr strings, not macros, to match Derecho's usage of these types of constants for Conf strings.
1 parent c2f0673 commit e2821f8

6 files changed

Lines changed: 208 additions & 160 deletions

File tree

include/cascade/detail/service_impl.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2440,7 +2440,7 @@ void ExecutionEngine<CascadeTypes...>::workhorse(uint32_t worker_id, struct acti
24402440
dbg_default_trace("Cascade context workhorse[{}] started", worker_id);
24412441
while(is_running) {
24422442
// waiting for an action
2443-
Action action = std::move(aq.action_buffer_dequeue(is_running));
2443+
Action action = aq.action_buffer_dequeue(is_running);
24442444
// if action_buffer_dequeue return with is_running == false, value_ptr is invalid(nullptr).
24452445
action.fire(this,worker_id);
24462446

0 commit comments

Comments
 (0)