Skip to content

Commit 2247e45

Browse files
authored
Merge pull request #285 from Derecho-Project/spdlog_15_update
Update spdlog usage to remain compatible with the latest version
2 parents cbac5e0 + c71260d commit 2247e45

4 files changed

Lines changed: 13 additions & 4 deletions

File tree

include/derecho/core/detail/p2p_connection.hpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,3 +185,11 @@ class P2PConnection {
185185

186186
};
187187
} // namespace sst
188+
189+
/**
190+
* Formatter template specialization specifying that sst::MESSAGE_TYPE should
191+
* be converted to a string using its ostream operator. Boilerplate needed by
192+
* the spdlog library.
193+
*/
194+
template <>
195+
struct fmt::formatter<sst::MESSAGE_TYPE> : fmt::ostream_formatter {};

include/derecho/utils/logger.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <spdlog/spdlog.h>
1111
#include <spdlog/fmt/ostr.h>
1212
#include <spdlog/fmt/ranges.h>
13+
#include <spdlog/fmt/std.h>
1314
#include <spdlog/sinks/rotating_file_sink.h>
1415
#include <spdlog/sinks/stdout_color_sinks.h>
1516

src/applications/tests/unit_tests/persistence_notification_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ void StorageNode::notification_thread_function() {
8686
for(auto requests_iter = requests_by_version.begin();
8787
requests_iter != requests_by_version.end();) {
8888
persistent::version_t requested_version = requests_iter->first;
89-
dbg_default_debug("Notification thread checking a notification of type {} for version {}", requests_iter->second.notification_type, requested_version);
89+
dbg_default_debug("Notification thread checking a notification of type {} for version {}", static_cast<uint64_t>(requests_iter->second.notification_type), requested_version);
9090
bool requested_event_happened = false;
9191
{
9292
std::unique_lock<std::mutex> query_results_lock(notification_thread_mutex);

src/core/git_version.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66
* local repository's .git/hooks/ directory.
77
*/
88

9-
#include <derecho/core/git_version.hpp>
9+
#include "derecho/core/git_version.hpp"
1010

1111
namespace derecho {
1212

1313
const int MAJOR_VERSION = 2;
1414
const int MINOR_VERSION = 4;
1515
const int PATCH_VERSION = 1;
16-
const int COMMITS_AHEAD_OF_VERSION = 0;
16+
const int COMMITS_AHEAD_OF_VERSION = 2;
1717
const char* VERSION_STRING = "2.4.1";
18-
const char* VERSION_STRING_PLUS_COMMITS = "2.4.1+0";
18+
const char* VERSION_STRING_PLUS_COMMITS = "2.4.1+2";
1919

2020
}

0 commit comments

Comments
 (0)