Fix Workshop Magic filter by mapping it to Spell ItemType. Added unit test for Workshop filtering.

Author: DerekGooding

Mythril.Blazor/Components/Workshop.razor

@@ -37,19 +37,25 @@
                     .Where(rd => {
                         if (_activeFilter == "All") return true;
 
-                        // Check if output matches filter
-                        var outType = rd.Recipe.OutputItem.ItemType.ToString() + "s";
-                        if (outType.Contains(_activeFilter, StringComparison.OrdinalIgnoreCase)) return true;
+                        // Map filter to ItemType string
+                        var filterType = _activeFilter switch {
+                            "Magic" => "Spell",
+                            "Materials" => "Material",
+                            _ => _activeFilter
+                        };
+
+                        var outType = rd.Recipe.OutputItem.ItemType.ToString();
+                        if (outType.Equals(filterType, StringComparison.OrdinalIgnoreCase)) return true;
 
                         // If output is NOT a standard Material/Spell category (e.g. Currency like Gold)
                         // then check if the INPUT matches the filter.
-                        bool outputIsStandard = outType.Contains("Material", StringComparison.OrdinalIgnoreCase) || 
-                                              outType.Contains("Spell", StringComparison.OrdinalIgnoreCase);
+                        bool outputIsStandard = outType.Equals("Material", StringComparison.OrdinalIgnoreCase) || 
+                                              outType.Equals("Spell", StringComparison.OrdinalIgnoreCase);
 
                         if (!outputIsStandard)
                         {
-                            var inType = rd.InputItem.ItemType.ToString() + "s";
-                            return inType.Contains(_activeFilter, StringComparison.OrdinalIgnoreCase);
+                            var inType = rd.InputItem.ItemType.ToString();
+                            return inType.Equals(filterType, StringComparison.OrdinalIgnoreCase);
                         }
 
                         return false;

Mythril.Tests/WorkshopComponentTests.cs

@@ -65,4 +65,55 @@ public void RefinementCard_RendersCorrectly()
         var iconHtml = cut.Find(".character-access").InnerHtml;
         Assert.Contains("person", iconHtml); // Protagonist icon
     }
+
+    [TestMethod]
+    public void Workshop_Filtering_Works()
+    {
+        // Arrange
+        var resourceManager = Services.GetRequiredService<ResourceManager>();
+        var items = ContentHost.GetContent<Items>().All;
+        var scrap = items.First(i => i.Name == SandboxContent.Scrap);
+        var gold = items.First(i => i.Name == SandboxContent.Gold);
+        var basicGem = items.First(i => i.Name == SandboxContent.BasicGem);
+        var fireI = items.First(i => i.Name == SandboxContent.FireI);
+
+        // Gold is Currency, Scrap is Material, BasicGem is Material, FireI is Spell
+        Assert.AreEqual(ItemType.Currency, gold.ItemType);
+        Assert.AreEqual(ItemType.Material, scrap.ItemType);
+        Assert.AreEqual(ItemType.Material, basicGem.ItemType);
+        Assert.AreEqual(ItemType.Spell, fireI.ItemType);
+
+        // Setup abilities
+        resourceManager.UnlockAbility(SandboxContent.Recruit, SandboxContent.RefineScrap);
+        resourceManager.UnlockAbility(SandboxContent.Student, SandboxContent.RefineFire);
+
+        var unlockedAbilities = new HashSet<string> { 
+            $"{SandboxContent.Recruit}:{SandboxContent.RefineScrap}",
+            $"{SandboxContent.Student}:{SandboxContent.RefineFire}"
+        };
+
+        // Act & Assert
+        var cut = RenderComponent<Workshop>(parameters => parameters
+            .Add(p => p.UnlockedAbilities, unlockedAbilities)
+        );
+
+        // 1. Default (All)
+        var cards = cut.FindComponents<RefinementCard>();
+        Assert.AreEqual(2, cards.Count);
+
+        // 2. Filter by Magic
+        var magicFilter = cut.Find("[data-testid='workshop-filter-magic']");
+        magicFilter.Click();
+        cards = cut.FindComponents<RefinementCard>();
+        Assert.AreEqual(1, cards.Count);
+        Assert.AreEqual(SandboxContent.RefineFire, cards[0].Instance.Refinement.Ability.Name);
+
+        // 3. Filter by Materials
+        var materialsFilter = cut.Find("[data-testid='workshop-filter-materials']");
+        materialsFilter.Click();
+        cards = cut.FindComponents<RefinementCard>();
+        Assert.AreEqual(1, cards.Count);
+        // RefineScrap outputs Gold (Currency) but inputs Scrap (Material), so it should show up under Materials
+        Assert.AreEqual(SandboxContent.RefineScrap, cards[0].Instance.Refinement.Ability.Name);
+    }
 }

docs/Playtest_Feedback.md

@@ -54,6 +54,8 @@
 
 - Archive Sifting gives too many Lost Parchment. Lost Parchment does nothing. 
 
+- Gather moonberries isn't unlocking a futher quest line
+
 - Consider an appendix tab that lists and explains all unlocked items, locations, cadences and abilities. Make it searchable. 
 
 - UI quick reference in the Workshop to remind who has access to craft what. Character icons but will need to function differently than cadence equip UI because multiple characters can have access to the same refinement recipes. 

simulation_report.md

@@ -1,5 +1,5 @@
 # Game Content Health Report
-Generated: 2026-04-28 13:36:53
+Generated: 2026-04-28 13:46:31
 
 ## 💀 Reachability Analysis
 Total Quests Completed: 31
@@ -11,68 +11,68 @@ Routed Completion Time: 87.8m
 
 ## ⚖️ Economic Sustainability
 ### Sustainable Recurring Activities
-- Refine Ice:Moonberry->Ice I
-- Refine Earth:Crystal Shards->Earth I
-- Shatter the Crystals
-- Alchemy I:Basic Gem->Gold
-- Chop Wood
-- Refine Water:Blue Coral->Water I
-- Archive Sifting
-- Refine Life:Ancient Bark->Cure I
 - Refine Ice:Mana Leaf->Ice I
-- Refine Haste:Lost Parchment->Haste I
-- Refine Lightning:Ice Shard->Lightning I
-- High Altitude Survey
+- Refine Fire:Iron Ore->Fire I
 - Study Ancient Texts
-- Tutorial Section
-- Refine Mixology:Herb->Potion
-- Deep Sea Scavenge
-- Harvest Sea-Life
+- Alchemy I:Basic Gem->Gold
 - Refine Lightning:Fire Shard->Lightning I
-- Hunt Sand-Sharks
 - Hunt Spiders
+- Tutorial Section
+- Hunt Bats
+- Refine Scrap:Web->Gold
 - Refine Wood:Log->Herb
-- Refine Fire:Iron Ore->Fire I
+- Harvest Sea-Life
+- Refine Mixology:Herb->Potion
+- Hunt Slimes
+- Refine Water:Blue Coral->Water I
+- Shatter the Crystals
+- Scavenge Scrap
 - Power the Forge
-- Gather Moonberries
+- Refine Earth:Crystal Shards->Earth I
 - Mine Iron Ore
-- Hunt Slimes
-- Refine Scrap:Web->Gold
+- Chop Wood
+- Refine Lightning:Ice Shard->Lightning I
+- Archive Sifting
+- Refine Ice:Moonberry->Ice I
 - Refine Fire:Basic Gem->Fire I
-- Hunt Bats
-- Scavenge Scrap
 - Hunt Goblins
+- Deep Sea Scavenge
+- High Altitude Survey
+- Hunt Sand-Sharks
+- Refine Haste:Lost Parchment->Haste I
+- Gather Moonberries
+- Refine Life:Ancient Bark->Cure I
 
 ### ⚠️ Unsustainable Activities (Reachable but starving)
-- Refine Life:Solar Essence->Cure I
 - Alchemy II:Potion->Gold
-- Refine Scrap:Slime->Gold
+- Refine Life:Solar Essence->Cure I
 - Alchemy II:Sun-baked Scale->Gold
+- Refine Scrap:Slime->Gold
 
 ### Net Resource Rates (per second)
+- **Potion**: 4.9887/s
 - **Fire I**: 54.0445/s
-- **Herb**: 19.9549/s
-- **Sun-baked Scale**: 0.8315/s
+- **Cure I**: 24.9436/s
 - **Lightning I**: 49.8873/s
+- **Water I**: 105.1123/s
+- **Herb**: 19.9549/s
 - **Ice Shard**: 30.0487/s
-- **Lost Parchment**: 3.3258/s
-- **Potion**: 4.9887/s
-- **Crystal Shards**: 7.4831/s
+- **Fire Shard**: 31.2959/s
+- **Ice I**: 49.8873/s
 - **Moonberry**: 21.2893/s
-- **Water I**: 105.1123/s
+- **Basic Gem**: 5.5225/s
+- **Lost Parchment**: 3.3258/s
+- **Slime**: 4.1573/s
 - **Earth I**: 24.9436/s
+- **Sun-baked Scale**: 0.8315/s
+- **Leather**: 26.2781/s
+- **Gold**: 6896.7448/s
 - **Mythril Spark**: 0.4157/s
 - **Log**: 4.9887/s
-- **Slime**: 4.1573/s
-- **Mana Leaf**: 5.3223/s
 - **Iron Ore**: 11.1049/s
-- **Basic Gem**: 5.5225/s
-- **Leather**: 26.2781/s
+- **Mana Leaf**: 5.3223/s
 - **Haste I**: 24.9436/s
-- **Fire Shard**: 31.2959/s
-- **Gold**: 6896.7448/s
-- **Cure I**: 24.9436/s
-- **Ice I**: 49.8873/s
+- **Crystal Shards**: 7.4831/s
 
 ## 🔄 Feedback Loops
 ✅ No unbounded growth loops detected (approximation).