CMS: Fix list deletion bug by using content-based row IDs; Finalize workshop sorting fallback

Author: DerekGooding

docs/Playtest_Feedback.md

@@ -6,6 +6,6 @@
 
 - [DONE] AutoQuest unlock no longer shows a toggle button to automate tasks. Review. (See [docs/resolution/2026-04-23_autoquest_toggle_fix.md](resolution/2026-04-23_autoquest_toggle_fix.md))
 
-- [DONE] Sorting of the workshop only sorts by the output item. But if the output is neither materials OR spells, it should revert to sorting by the input item. For example, some workshop refinement tasks turn gold into a material or a material into gold. Those should show up in the materials tab. (See [docs/resolution/2026-04-23_workshop_location_fix.md](resolution/2026-04-23_workshop_location_fix.md))
+- [DONE] Sorting of the workshop only sorts by the output item. But if the output is neither materials OR spells, it should revert to sorting by the input item. For example, some workshop refinement tasks turn gold into a material or a material into gold. Those should show up in the materials tab. (See [docs/resolution/2026-04-23_cms_deletion_and_sorting_fixes.md](resolution/2026-04-23_cms_deletion_and_sorting_fixes.md))
 
-- [DONE] The content manager should show what exists in a given location and allow modifying what quests exist in that given location. (See [docs/resolution/2026-04-23_workshop_location_fix.md](resolution/2026-04-23_workshop_location_fix.md))
+- [DONE] The content manager should show what exists in a given location and allow modifying what quests exist in that given location. (See [docs/resolution/2026-04-23_cms_deletion_and_sorting_fixes.md](resolution/2026-04-23_cms_deletion_and_sorting_fixes.md))

docs/resolution/2026-04-23_cms_deletion_and_sorting_fixes.md

@@ -0,0 +1,20 @@
+# Resolution: CMS Widget Identity & Workshop Refinement
+
+## Problems
+1.  **CMS Deletion Bug**: When deleting an item from a list (Requirements, Quests in Location, etc.) in the Content Manager, Streamlit would often remove the last item in the UI regardless of which "trashcan" button was clicked. This was caused by using simple indices for widget keys, leading to state-shifting issues when the list size changed.
+2.  **Workshop Visibility**: Some workshop tasks (like "Sell Gem") were not appearing in the expected tabs (e.g., Materials) because the filter only checked the output item type (Currency/Gold), ignoring the material nature of the input.
+
+## Technical Resolution
+1.  **Robust Key Generation**:
+    *   Updated all editor components in `modules/contentManager/ui_components.py` (`edit_list`, `edit_dict_list`, `edit_recipes`, `edit_cadence_abilities`, `edit_string_list`) to use a `row_id`.
+    *   `row_id` combines the loop index with the content of the row (e.g., item name or key), ensuring that Streamlit can uniquely identify each widget even when other rows are added or removed.
+    *   Applied `safe_key` (derived from the entity name) to the `Locations` quest editor in `app.py` to prevent state leakage between different locations.
+2.  **Workshop Filter Fallback**:
+    *   Refined the filtering logic in `Mythril.Blazor/Components/Workshop.razor`.
+    *   If a refinement's output type does not match the active filter (Materials or Spells), the filter now falls back to checking the **Input Item's type**.
+    *   This ensures that "Sell Gem" (Material -> Gold) is correctly listed under "Materials".
+
+## Verification
+*   Verified through health check that all 205 unit tests pass.
+*   Verified that reachability and economic sustainability simulations pass.
+*   The `content_graph.json` was successfully re-synchronized and verified with 0 violations.

modules/contentManager/app.py

@@ -168,7 +168,7 @@
     elif page == "Locations":
         st.subheader("🗺️ Quests in Location")
         if "Quests" not in item: item["Quests"] = []
-        ui.edit_string_list(manager, item["Quests"], [q["Name"] for q in manager.unified_data["quests"]], "location_quests")
+        ui.edit_string_list(manager, item["Quests"], [q["Name"] for q in manager.unified_data["quests"]], f"location_quests_{safe_key}")
 
     elif page == "Abilities":
         st.info("Abilities themselves are simple Name/Description. Use the Cadence page to assign them and define requirements.")

modules/contentManager/ui_components.py

@@ -6,20 +6,22 @@ def edit_list(manager, data_list, key_prefix, item_pool=None):
 
     to_delete = None
     for i, entry in enumerate(data_list):
+        # Use content in key to help Streamlit track identity when rows shift
+        row_id = f"{i}_{entry.get('Item', 'none')}"
         col1, col2, col3 = st.columns([3, 2, 1])
         with col1:
             current_index = 0
             if entry["Item"] in item_pool:
                 current_index = item_pool.index(entry["Item"])
 
-            new_name = st.selectbox(f"Item {i}", item_pool, index=current_index, key=f"{key_prefix}_name_{i}")
+            new_name = st.selectbox(f"Item {i}", item_pool, index=current_index, key=f"{key_prefix}_name_{row_id}")
             entry["Item"] = new_name
 
         with col2:
-            entry["Quantity"] = st.number_input(f"Qty {i}", value=entry["Quantity"], min_value=1, key=f"{key_prefix}_qty_{i}")
+            entry["Quantity"] = st.number_input(f"Qty {i}", value=entry["Quantity"], min_value=1, key=f"{key_prefix}_qty_{row_id}")
 
         with col3:
-            if st.button("🗑️", key=f"{key_prefix}_del_{i}"):
+            if st.button("🗑️", key=f"{key_prefix}_del_{row_id}"):
                 to_delete = i
 
     if to_delete is not None:
@@ -34,23 +36,24 @@ def edit_dict_list(manager, data_dict, key_prefix, label_name="Stat"):
     to_delete = None
     keys = list(data_dict.keys())
     for i, key in enumerate(keys):
+        row_id = f"{i}_{key}"
         col1, col2, col3 = st.columns([3, 2, 1])
         with col1:
             stat_names = [s["Name"] for s in manager.unified_data["stats"]]
             current_index = 0
             if key in stat_names:
                 current_index = stat_names.index(key)
 
-            new_key = st.selectbox(f"{label_name} {i}", stat_names, index=current_index, key=f"{key_prefix}_key_{i}")
+            new_key = st.selectbox(f"{label_name} {i}", stat_names, index=current_index, key=f"{key_prefix}_key_{row_id}")
             if new_key != key:
                 data_dict[new_key] = data_dict.pop(key)
                 st.rerun()
 
         with col2:
-            data_dict[new_key] = st.number_input(f"Value {i}", value=data_dict[new_key], key=f"{key_prefix}_val_{i}")
+            data_dict[new_key] = st.number_input(f"Value {i}", value=data_dict[new_key], key=f"{key_prefix}_val_{row_id}")
 
         with col3:
-            if st.button("🗑️", key=f"{key_prefix}_del_{i}"):
+            if st.button("🗑️", key=f"{key_prefix}_del_{row_id}"):
                 to_delete = key
 
     if to_delete is not None:
@@ -67,18 +70,19 @@ def edit_recipes(manager, recipes, key_prefix):
     to_delete = None
     item_names = [i["Name"] for i in manager.unified_data["items"]]
     for i, recipe in enumerate(recipes):
+        row_id = f"{i}_{recipe['InputItem']}_{recipe['OutputItem']}"
         with st.container(border=True):
             col1, col2, col3, col4, col5 = st.columns([2, 1, 2, 1, 0.5])
             with col1:
-                recipe["InputItem"] = st.selectbox("In", item_names, index=item_names.index(recipe["InputItem"]) if recipe["InputItem"] in item_names else 0, key=f"{key_prefix}_in_{i}")
+                recipe["InputItem"] = st.selectbox("In", item_names, index=item_names.index(recipe["InputItem"]) if recipe["InputItem"] in item_names else 0, key=f"{key_prefix}_in_{row_id}")
             with col2:
-                recipe["InputQuantity"] = st.number_input("Qty", value=recipe["InputQuantity"], min_value=1, key=f"{key_prefix}_in_q_{i}")
+                recipe["InputQuantity"] = st.number_input("Qty", value=recipe["InputQuantity"], min_value=1, key=f"{key_prefix}_in_q_{row_id}")
             with col3:
-                recipe["OutputItem"] = st.selectbox("Out", item_names, index=item_names.index(recipe["OutputItem"]) if recipe["OutputItem"] in item_names else 0, key=f"{key_prefix}_out_{i}")
+                recipe["OutputItem"] = st.selectbox("Out", item_names, index=item_names.index(recipe["OutputItem"]) if recipe["OutputItem"] in item_names else 0, key=f"{key_prefix}_out_{row_id}")
             with col4:
-                recipe["OutputQuantity"] = st.number_input("Qty", value=recipe["OutputQuantity"], min_value=1, key=f"{key_prefix}_out_q_{i}")
+                recipe["OutputQuantity"] = st.number_input("Qty", value=recipe["OutputQuantity"], min_value=1, key=f"{key_prefix}_out_q_{row_id}")
             with col5:
-                if st.button("🗑️", key=f"{key_prefix}_del_{i}"):
+                if st.button("🗑️", key=f"{key_prefix}_del_{row_id}"):
                     to_delete = i
 
     if to_delete is not None:
@@ -119,21 +123,22 @@ def edit_cadence_abilities(manager, abilities_list, key_prefix):
     stat_names = [s["Name"] for s in manager.unified_data["stats"]]
 
     for i, ab_entry in enumerate(abilities_list):
+        row_id = f"{i}_{ab_entry.get('Ability', 'none')}"
         with st.container(border=True):
             col1, col2, col3 = st.columns([3, 2, 1])
             with col1:
                 # The structure in JSON is {"Ability": "Name", "Requirements": [...], "PrimaryStat": "..."}
                 current_ab_name = ab_entry["Ability"]
-                new_ab_name = st.selectbox(f"Ability {i}", all_ability_names, index=all_ability_names.index(current_ab_name) if current_ab_name in all_ability_names else 0, key=f"{key_prefix}_ab_{i}")
+                new_ab_name = st.selectbox(f"Ability {i}", all_ability_names, index=all_ability_names.index(current_ab_name) if current_ab_name in all_ability_names else 0, key=f"{key_prefix}_ab_{row_id}")
 
                 if new_ab_name != current_ab_name:
                     ab_entry["Ability"] = new_ab_name
 
             with col2:
-                ab_entry["PrimaryStat"] = st.selectbox(f"Stat {i}", stat_names, index=stat_names.index(ab_entry["PrimaryStat"]) if ab_entry.get("PrimaryStat") in stat_names else 0, key=f"{key_prefix}_stat_{i}")
+                ab_entry["PrimaryStat"] = st.selectbox(f"Stat {i}", stat_names, index=stat_names.index(ab_entry["PrimaryStat"]) if ab_entry.get("PrimaryStat") in stat_names else 0, key=f"{key_prefix}_stat_{row_id}")
 
             with col3:
-                if st.button("🗑️ Remove Ability", key=f"{key_prefix}_del_{i}"):
+                if st.button("🗑️ Remove Ability", key=f"{key_prefix}_del_{row_id}"):
                     to_delete = i
 
             # Find the original ability definition to show/edit its effects
@@ -142,13 +147,13 @@ def edit_cadence_abilities(manager, abilities_list, key_prefix):
             # But the C# code looks at unlock.Ability.Effects.
 
             st.write("**Requirements**")
-            edit_list(manager, ab_entry["Requirements"], f"{key_prefix}_req_{i}")
+            edit_list(manager, ab_entry["Requirements"], f"{key_prefix}_req_{row_id}")
 
             if "Effects" not in ab_entry:
                 ab_entry["Effects"] = []
 
             st.write("**Effects**")
-            edit_effects(manager, ab_entry["Effects"], f"{key_prefix}_eff_{i}")
+            edit_effects(manager, ab_entry["Effects"], f"{key_prefix}_eff_{row_id}")
 
     if to_delete is not None:
         abilities_list.pop(to_delete)
@@ -167,16 +172,17 @@ def edit_cadence_abilities(manager, abilities_list, key_prefix):
 def edit_string_list(manager, string_list, pool, key_prefix):
     to_delete = None
     for i, s in enumerate(string_list):
+        row_id = f"{i}_{s}"
         col1, col2 = st.columns([5, 1])
         with col1:
             current_index = 0
             if s in pool:
                 current_index = pool.index(s)
 
-            new_val = st.selectbox(f"Entry {i}", pool, index=current_index, key=f"{key_prefix}_{i}")
+            new_val = st.selectbox(f"Entry {i}", pool, index=current_index, key=f"{key_prefix}_{row_id}")
             string_list[i] = new_val
         with col2:
-            if st.button("🗑️", key=f"{key_prefix}_del_{i}"):
+            if st.button("🗑️", key=f"{key_prefix}_del_{row_id}"):
                 to_delete = i
 
     if to_delete is not None:

simulation_report.md

@@ -1,5 +1,5 @@
 # Game Content Health Report
-Generated: 2026-04-23 10:16:33
+Generated: 2026-04-23 10:46:47
 
 ## 💀 Reachability Analysis
 Total Quests Completed: 36
@@ -9,70 +9,70 @@ Routed Completion Time: 65.5m
 
 ## ⚖️ Economic Sustainability
 ### Sustainable Recurring Activities
+- Power the Forge
+- Chop Wood
+- Refine Fire:Iron Ore->Fire I
+- Refine Scrap:Slime->Gold
+- Shatter the Crystals
+- Tutorial Section
 - Refine Life:Ancient Bark->Cure I
-- Hunt Goblins
-- Alchemy I:Basic Gem->Gold
-- Study Ancient Texts
-- Hunt Spiders
-- Mine Iron Ore
-- Refine Water:Blue Coral->Water I
-- Refine Mixology:Herb->Potion
 - Refine Haste:Lost Parchment->Haste I
-- Refine Fire:Basic Gem->Fire I
-- Hunt Bats
-- Shatter the Crystals
 - Refine Earth:Crystal Shards->Earth I
-- Purify the Grove
+- Hunt Bats
+- Scavenge Scrap
+- Study Ancient Texts
+- Alchemy I:Basic Gem->Gold
+- Refine Scrap:Web->Gold
+- Refine Ice:Moonberry->Ice I
+- Refine Mixology:Herb->Potion
+- Mine Iron Ore
+- Hunt Sand-Sharks
+- Refine Wood:Log->Herb
+- High Altitude Survey
+- Refine Ice:Mana Leaf->Ice I
+- Hunt Spiders
 - Harvest Sea-Life
-- Deep Sea Scavenge
 - Refine Lightning:Ice Shard->Lightning I
-- Refine Scrap:Web->Gold
+- Hunt Slimes
+- Refine Fire:Basic Gem->Fire I
+- Refine Water:Blue Coral->Water I
 - Archive Sifting
-- Scavenge Scrap
-- High Altitude Survey
-- Chop Wood
-- Refine Fire:Iron Ore->Fire I
+- Deep Sea Scavenge
+- Hunt Goblins
+- Gather Moonberries
+- Purify the Grove
 - Buy Potion
-- Refine Scrap:Slime->Gold
-- Tutorial Section
 - Refine Lightning:Fire Shard->Lightning I
-- Gather Moonberries
-- Hunt Slimes
-- Hunt Sand-Sharks
-- Refine Ice:Moonberry->Ice I
-- Power the Forge
-- Refine Wood:Log->Herb
-- Refine Ice:Mana Leaf->Ice I
 
 ### ⚠️ Unsustainable Activities (Reachable but starving)
 - Sell Gem
 
 ### Net Resource Rates (per second)
-- **Log**: 4.9887/s
-- **Moonberry**: 21.2893/s
-- **Haste I**: 24.9436/s
-- **Ice Shard**: 30.0487/s
-- **Sun-baked Scale**: 0.8315/s
-- **Ancient Bark**: 6.2359/s
-- **Cure I**: 12.4718/s
-- **Basic Gem**: 5.5225/s
+- **Water I**: 105.1123/s
 - **Lightning I**: 49.8873/s
-- **Iron Ore**: 11.1049/s
-- **Crystal Shards**: 7.4831/s
+- **Slime**: 20.5503/s
+- **Herb**: 19.9549/s
+- **Basic Gem**: 5.5225/s
+- **Cure I**: 12.4718/s
 - **Gold**: 5793.0658/s
-- **Mana Leaf**: 5.3223/s
-- **Fire Shard**: 31.2959/s
-- **Earth I**: 24.9436/s
-- **Ice I**: 49.8873/s
 - **Water**: 52.5561/s
-- **Slime**: 20.5503/s
 - **Potion**: 68.0561/s
+- **Ice Shard**: 30.0487/s
+- **Ice I**: 49.8873/s
+- **Fire I**: 29.1009/s
+- **Earth I**: 24.9436/s
+- **Sun-baked Scale**: 0.8315/s
+- **Fire Shard**: 31.2959/s
+- **Iron Ore**: 11.1049/s
+- **Ancient Bark**: 6.2359/s
+- **Moonberry**: 21.2893/s
+- **Log**: 4.9887/s
 - **Lost Parchment**: 3.3258/s
-- **Herb**: 19.9549/s
-- **Water I**: 105.1123/s
-- **Mythril Spark**: 0.4157/s
 - **Leather**: 26.2781/s
-- **Fire I**: 29.1009/s
+- **Mana Leaf**: 5.3223/s
+- **Crystal Shards**: 7.4831/s
+- **Haste I**: 24.9436/s
+- **Mythril Spark**: 0.4157/s
 
 ## 🔄 Feedback Loops
 ✅ No unbounded growth loops detected (approximation).