Ignore custom app space management activities

Allowing apps to override the "Clear storage" function makes users
powerless when it comes to clearing the data of a rogue app, short of
reinstalling the entire app. I've never seen an app that uses this in a
good way, so just remove it to allow clearing storage of any app.

The most prominent example of this is the Google Search (Velvet) app,
which does not allow the user to clear all data and leaves up to 100 MB
of wasted space even after clearing storage in its custom space manager.
It's also impossible to clear its data after disabling the app, which
forces users to deal with wasted space for no reason.

Change-Id: Ib80d4741750bcbb5c6e1dd844aa763ce4e24854c

Author: kdrag0n

src/com/android/settings/applications/AppStorageSettings.java

@@ -209,13 +209,6 @@ void handleClearDataClick() {
         if (mAppsControlDisallowedAdmin != null && !mAppsControlDisallowedBySystem) {
             RestrictedLockUtils.sendShowAdminSupportDetailsIntent(
                     getActivity(), mAppsControlDisallowedAdmin);
-        } else if (mAppEntry.info.manageSpaceActivityName != null) {
-            if (!Utils.isMonkeyRunning()) {
-                Intent intent = new Intent(Intent.ACTION_DEFAULT);
-                intent.setClassName(mAppEntry.info.packageName,
-                        mAppEntry.info.manageSpaceActivityName);
-                startActivityForResult(intent, REQUEST_MANAGE_SPACE);
-            }
         } else {
             showDialogInner(DLG_CLEAR_DATA, 0);
         }
@@ -299,11 +292,8 @@ private void initDataButtons() {
         if (appHasSpaceManagementUI) {
             intent.setClassName(mAppEntry.info.packageName, mAppEntry.info.manageSpaceActivityName);
         }
-        final boolean isManageSpaceActivityAvailable =
-                getPackageManager().resolveActivity(intent, 0) != null;
 
-        if ((!appHasSpaceManagementUI && appRestrictsClearingData)
-                || !isManageSpaceActivityAvailable) {
+        if (!appHasSpaceManagementUI && appRestrictsClearingData) {
             mButtonsPref
                     .setButton1Text(R.string.clear_user_data_text)
                     .setButton1Icon(R.drawable.ic_settings_delete)