Fix a case of static initialization order debacle

When descent3 is built with g++ -flto=auto, there is a crash at startup:

```
Program received signal SIGSEGV, Segmentation fault.
0x00005555557b3b20 in pilot::initialize (
    this=this@entry=0x555555fbd480 <Current_pilot>)
    at Descent3/pilot_class.cpp:208
208       game_window_w = Video_res_list[Current_video_resolution_id].width;
Missing separate debuginfos, use: zypper install libcpp-httplib0_20-debuginfo-0.20.1-2.1.x86_64 libSDL3-0-debuginfo-3.2.16-1.1.x86_64 libzstd1-x86-64-v3-debuginfo-1.5.7-3.1.x86_64
(gdb) p Current_video_resolution_id
$1 = 0
(gdb) p Video_res_list
$2 = std::vector of length 0, capacity 0

(gdb) bt
f0  pilot::initialize (this=this@entry=0x555555fbd480 <Current_pilot>) at Descent3/pilot_class.cpp:208
f1  pilot::pilot (this=<optimized out>, this=<optimized out>) at Descent3/pilot_class.cpp:177
f2  _sub_I_65535_0.0 ()
f3  call_init (argc=1, argv=0x7fffffffdb68, env=<optimized out>) at ../csu/libc-start.c:145
f4  __libc_start_main_impl
f5  _start () at ../sysdeps/x86_64/start.S:115
```

When ASAN/UBSAN is enabled in conjunction with LTO:

```
/usr/include/c++/14/bits/stl_vector.h:1144:34: runtime error: reference binding to null pointer of type 'struct value_type'
Descent3/pilot_class.cpp:208:63: runtime error: member access within null pointer of type 'struct value_type'
AddressSanitizer:DEADLYSIGNAL
=================================================================
==58724==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000
==58724==The signal is caused by a READ memory access.
==58724==Hint: address points to the zero page.
    f0 pilot::initialize() Descent3/pilot_class.cpp:208
    f1 pilot::pilot() Descent3/pilot_class.cpp:177
    f2 _sub_I_65535_0.0 (b/build/Descent3+0x52ece3)
    f3 call_init ../csu/libc-start.c:145
    f4 __libc_start_main_impl ../csu/libc-start.c:347
    f5 _start ../sysdeps/x86_64/start.S:115
```

``_sub_I_65535_0.0`` is indicative of a global constructor, so we
are looking at a case of Static Initialization Order Fiasco whereby
``pilot::initialize`` runs before ``Video_res_list`` and
``Current_resolution_id`` get initialized.

Perform pilot construction explicitly in main().

Fixes: 40c7f0d

Author: jengelh

Descent3/pilot.cpp

@@ -696,6 +696,11 @@ void PilotShutdown() {
   Current_pilot.clean(false);
 }
 
+void PilotEarlyInit()
+{
+  Current_pilot.initialize();
+}
+
 void PilotInit() {
   PilotInitData(&Current_pilot);
   atexit(PilotShutdown);

Descent3/pilot_class.cpp

@@ -177,10 +177,9 @@ pilot::pilot() :
 	hud_mode{HUD_COCKPIT},
 	hud_graphical_stat{STAT_STANDARD}
 {
-  initialize();
 }
 
-// initializes all the data (for constructors)
+// Two-stage construction (because it references global vars)
 void pilot::initialize(void) {
   int i;
 

Descent3/pilot_class.h

@@ -233,8 +233,8 @@ class pilot {
   void get_mission_data(int index, tMissionData *data);
   int find_mission_data(const char *mission_name);
 
-private:
   void initialize(void); // initializes all the data (for constructors)
+private:
   bool write_pending = false; // data has changed and pilot data is out of sync with file
 private:
   // internal file access functions

Descent3/sdlmain.cpp

@@ -45,6 +45,7 @@
 #include "init.h"
 #include "log.h"
 #include "config.h"
+#include "pilot.h"
 
 #ifdef WIN32
 #include "debug.h"
@@ -222,6 +223,7 @@ int main(int argc, char *argv[]) {
   GatherArgs(argv);
   bool enable_winconsole = true;
 #endif
+  Current_pilot.initialize();
 
   orig_pwd = std::filesystem::current_path();