Skip to content

Commit 4654e3d

Browse files
committed
Evaluating OpenFOAM jobs
1 parent 2065ae8 commit 4654e3d

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,3 +175,4 @@ cython_debug/
175175
*.log
176176
*.sqlite
177177

178+
.aider*

dapi/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,8 +311,8 @@ def generate_request(
311311
self,
312312
app_id: str,
313313
input_dir_uri: str,
314-
script_filename: str,
315314
# --- Optional Overrides ---
315+
script_filename: Optional[str] = None,
316316
app_version: Optional[str] = None,
317317
job_name: Optional[str] = None,
318318
description: Optional[str] = None,

dapi/jobs.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def generate_job_request(
3737
tapis_client: Tapis,
3838
app_id: str,
3939
input_dir_uri: str,
40-
script_filename: str,
40+
script_filename: Optional[str] = None,
4141
app_version: Optional[str] = None,
4242
job_name: Optional[str] = None,
4343
description: Optional[str] = None,
@@ -251,7 +251,15 @@ def generate_job_request(
251251
script_param_added = True
252252
break
253253
if not script_param_added:
254-
raise ValueError(f"Could not find where to place the script parameter...")
254+
# Check if appArgs is empty - if so, skip script parameter requirement
255+
if hasattr(param_set_def, "appArgs") and param_set_def.appArgs == []:
256+
print(
257+
"App has empty appArgs list - skipping script parameter placement"
258+
)
259+
else:
260+
raise ValueError(
261+
f"Could not find where to place the script parameter..."
262+
)
255263
if extra_app_args:
256264
job_req["parameterSet"]["appArgs"].extend(extra_app_args)
257265
if extra_env_vars:

0 commit comments

Comments
 (0)