Skip to content

Updated dapi with OpenSees, MPM and Apps example#2

Merged
kks32 merged 31 commits into
mainfrom
dev
Jun 6, 2025
Merged

Updated dapi with OpenSees, MPM and Apps example#2
kks32 merged 31 commits into
mainfrom
dev

Conversation

@kks32
Copy link
Copy Markdown
Collaborator

@kks32 kks32 commented Jun 6, 2025

Getting ready for 0.3.0

@kks32 kks32 self-assigned this Jun 6, 2025
@kks32 kks32 requested a review from Copilot June 6, 2025 11:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the 0.3.0 release by removing the legacy job-submission code and adding new database, authentication, exception, and application-discovery modules, along with documentation and CI updates.

  • Removed old dapi/jobs code and updated package exports
  • Introduced custom exceptions, database connectors, and lazy database accessor
  • Added revamped auth and app-discovery modules, updated README, and CI workflows

Reviewed Changes

Copilot reviewed 84 out of 84 changed files in this pull request and generated 1 comment.

File Description
dapi/db/db.py Added new DSDatabase implementation (note missing imports for sessionmaker and text).
dapi/init.py Updated package exports (imports outdated jobs, and typo in __all__).
.github/workflows/build-test.yml Updated Python/Poetry versions but removed the pytest step.
dapi/db_config.py & dapi/db/config.py Duplicate database-config mappings in two modules.
Comments suppressed due to low confidence (4)

dapi/db/db.py:24

  • The DSDatabase implementation uses sessionmaker and text(...) but they are not imported. Add from sqlalchemy.orm import sessionmaker and from sqlalchemy import text at the top of the file.
from sqlalchemy import create_engine, exc

.github/workflows/build-test.yml:23

  • The CI workflow no longer runs the pytest step, which means commits won’t be validated against tests. Re-enable poetry run pytest -v to ensure test coverage in CI.
-      - name: Run the automated tests

dapi/init.py:69

  • The dapi/jobs module has been removed, but this import remains. Update or remove the outdated import of SubmittedJob and related names from .jobs.
from .jobs import (

dapi/init.py:113

  • Missing comma between string literals concatenates them into one entry. It should be "SystemInfoError", "JobSubmissionError",.
"SystemInfoError" "JobSubmissionError",

Comment thread dapi/db_config.py Outdated
@kks32 kks32 merged commit 9d2ddb8 into main Jun 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants