Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the 0.3.0 release by removing the legacy job-submission code and adding new database, authentication, exception, and application-discovery modules, along with documentation and CI updates.
- Removed old
dapi/jobscode and updated package exports - Introduced custom exceptions, database connectors, and lazy database accessor
- Added revamped auth and app-discovery modules, updated README, and CI workflows
Reviewed Changes
Copilot reviewed 84 out of 84 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dapi/db/db.py | Added new DSDatabase implementation (note missing imports for sessionmaker and text). |
| dapi/init.py | Updated package exports (imports outdated jobs, and typo in __all__). |
| .github/workflows/build-test.yml | Updated Python/Poetry versions but removed the pytest step. |
| dapi/db_config.py & dapi/db/config.py | Duplicate database-config mappings in two modules. |
Comments suppressed due to low confidence (4)
dapi/db/db.py:24
- The
DSDatabaseimplementation usessessionmakerandtext(...)but they are not imported. Addfrom sqlalchemy.orm import sessionmakerandfrom sqlalchemy import textat the top of the file.
from sqlalchemy import create_engine, exc
.github/workflows/build-test.yml:23
- The CI workflow no longer runs the pytest step, which means commits won’t be validated against tests. Re-enable
poetry run pytest -vto ensure test coverage in CI.
- - name: Run the automated tests
dapi/init.py:69
- The
dapi/jobsmodule has been removed, but this import remains. Update or remove the outdated import ofSubmittedJoband related names from.jobs.
from .jobs import (
dapi/init.py:113
- Missing comma between string literals concatenates them into one entry. It should be
"SystemInfoError", "JobSubmissionError",.
"SystemInfoError" "JobSubmissionError",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting ready for 0.3.0