bug/WA-529: Fix to Vista version of Jupyter HPC Native#1708
Open
fnets wants to merge 3 commits into
Open
Conversation
…s with the same id, but different versions for simplicity and it is causing the wrong apps to be pulled for layout purposes.
rstijerina
reviewed
May 22, 2026
rstijerina
reviewed
May 26, 2026
| for (const category of data.categories) { | ||
| for (const app of category.apps) { | ||
| if (app.app_id === appId) { | ||
| if (app.app_id === appId && app.version === version) { |
Member
There was a problem hiding this comment.
Does this still find the app if the app listing entry does not specify a version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
The Vista version of Jupyter HPC Native had Stampede3 in the title (see screenshot)
PR Status:
Related Jira tickets:
Summary of Changes:
Added version check to findAppById because we are starting to use apps with the same id, but different versions for simplicity and it is causing the wrong apps to be pulled for layout purposes.
Testing Steps:
UI Photos:
Notes: