Merge pull request #370 from Dessia-tech/fix/mpl-plot-colors

Fix LineSegment edge_style when using mpl_plot

Author: Tanguylo

CHANGELOG.md

@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Add
 - Allow to directly specify if axes are on or off in Python
 
+### Fix
+- LineSegment2D : If it is overloaded, MPL Plot now show the right edge_style instead of generating of random one
+
+
 ## [0.23.0]
 ### Feat
 - Add events (Subject) to emit shape hovering and clicking

plot_data/core.py

@@ -503,7 +503,6 @@ def mpl_plot(self, ax=None, edge_style=None, **kwargs):
         if ax is None:
             _, ax = plt.subplots()
 
-        style = self.edge_style
         if edge_style:
             style = edge_style
             color = style.color_stroke.rgb
@@ -534,9 +533,8 @@ def __init__(self, point1: List[float], point2: List[float], edge_style: EdgeSty
         self.point2 = point2
 
         if edge_style is None:
-            self.edge_style = EdgeStyle()
-        else:
-            self.edge_style = edge_style
+            edge_style = EdgeStyle()
+        self.edge_style = edge_style
         super().__init__(type_='linesegment2d', reference_path=reference_path, tooltip=tooltip, name=name)
 
     def bounding_box(self):
@@ -555,10 +553,11 @@ def mpl_plot(self, ax=None, edge_style=None, **kwargs):
         if not ax:
             _, ax = plt.subplots()
 
-        if edge_style:
-            edge_style = self.edge_style
-        else:
-            edge_style = DEFAULT_EDGESTYLE
+        if edge_style is None:
+            if self.edge_style:
+                edge_style = self.edge_style
+            else:
+                edge_style = DEFAULT_EDGESTYLE
 
         ax.plot([self.point1[0], self.point2[0]], [self.point1[1], self.point2[1]], **edge_style.mpl_arguments(),
                 **kwargs)
@@ -635,7 +634,6 @@ def mpl_plot(self, ax=None, **kwargs):
             edge_style = self.edge_style
         else:
             edge_style = DEFAULT_EDGESTYLE
-            # dashes = DEFAULT_EDGESTYLE.dashline
         args = edge_style.mpl_arguments(surface=True)
         if 'dashes' in args:
             args.pop("dashes")
@@ -676,7 +674,6 @@ def mpl_plot(self, ax=None, **kwargs):
             edge_style = self.edge_style
         else:
             edge_style = DEFAULT_EDGESTYLE
-            # dashes = DEFAULT_EDGESTYLE.dashline
         args = edge_style.mpl_arguments(surface=True)
         if 'dashes' in args:
             args.pop("dashes")