Fix validation for platform membership ID

Author: bhollis

api/db/index.ts

@@ -6,7 +6,7 @@ import { metrics } from '../metrics/index.js';
 export const pool = new pg.Pool({
   max: 4,
   ssl: process.env.PGSSL ? process.env.PGSSL === 'true' : { rejectUnauthorized: false },
-  connectionTimeoutMillis: 500,
+  connectionTimeoutMillis: 1000,
   // Query timeout is on the NodeJS side, it times out the an operation on the client
   query_timeout: 2000,
 });

api/routes/update.ts

@@ -118,47 +118,47 @@ function validateUpdates(
         status: 'InvalidArgument',
         message: `${update.action} requires platform membership ID to be set`,
       };
-    }
+    } else {
+      switch (update.action) {
+        case 'tag_cleanup':
+        case 'delete_loadout':
+        case 'track_triumph':
+        case 'delete_search':
+          // no special validation
+          break;
 
-    switch (update.action) {
-      case 'tag_cleanup':
-      case 'delete_loadout':
-      case 'track_triumph':
-      case 'delete_search':
-        // no special validation
-        break;
-
-      case 'setting':
-        result = validateUpdateSettings(update.payload);
-        break;
-
-      case 'loadout':
-        result = validateUpdateLoadout(update.payload);
-        break;
-
-      case 'tag':
-        result = validateUpdateItemAnnotation(update.payload);
-        break;
-
-      case 'item_hash_tag':
-        result = validateUpdateItemHashTag(update.payload);
-        break;
-
-      case 'search':
-      case 'save_search':
-        result = validateSearch(update.payload);
-        break;
-
-      default:
-        console.warn(
-          `Unknown action type: ${(update as { action: string }).action} from ${appId}, ${req.header(
-            'User-Agent',
-          )}, ${req.header('Referer')}`,
-        );
-        result = {
-          status: 'InvalidArgument',
-          message: `Unknown action type: ${(update as { action: string }).action}`,
-        };
+        case 'setting':
+          result = validateUpdateSettings(update.payload);
+          break;
+
+        case 'loadout':
+          result = validateUpdateLoadout(update.payload);
+          break;
+
+        case 'tag':
+          result = validateUpdateItemAnnotation(update.payload);
+          break;
+
+        case 'item_hash_tag':
+          result = validateUpdateItemHashTag(update.payload);
+          break;
+
+        case 'search':
+        case 'save_search':
+          result = validateSearch(update.payload);
+          break;
+
+        default:
+          console.warn(
+            `Unknown action type: ${(update as { action: string }).action} from ${appId}, ${req.header(
+              'User-Agent',
+            )}, ${req.header('Referer')}`,
+          );
+          result = {
+            status: 'InvalidArgument',
+            message: `Unknown action type: ${(update as { action: string }).action}`,
+          };
+      }
     }
     if (result.status !== 'Success') {
       const dimVersion = req.headers['x-dim-version']?.[0];