Autobackfill migration state on update (#292)

* Autobackfill migration state on update

* Migrate table to have some indexes

* Don't check row count

Author: bhollis

api/db/migration-state-queries.ts

@@ -29,6 +29,20 @@ interface MigrationStateRow {
   last_error: string | null;
 }
 
+// This is a blind backfill that only adds missing rows - it doesn't update existing ones
+export async function backfillMigrationState(
+  client: ClientBase,
+  platformMembershipId: string,
+  bungieMembershipId: number,
+): Promise<void> {
+  await client.query({
+    name: 'backfill_migration_state',
+    text: `insert into migration_state (platform_membership_id, membership_id, state) VALUES ($1, $2, $3)
+on conflict (platform_membership_id) do nothing`,
+    values: [platformMembershipId, bungieMembershipId, MigrationState.Stately],
+  });
+}
+
 export async function getUsersToMigrate(client: ClientBase): Promise<number[]> {
   const results = await client.query<MigrationStateRow>({
     name: 'get_users_to_migrate',

api/migrations/20260117202138-migration-state-indexes.js

@@ -0,0 +1,39 @@
+'use strict';
+
+var dbm;
+var type;
+var seed;
+
+/**
+ * We receive the dbmigrate dependency from dbmigrate initially.
+ * This enables us to not have to rely on NODE_PATH.
+ */
+exports.setup = function (options, seedLink) {
+  dbm = options.dbmigrate;
+  type = dbm.dataType;
+  seed = seedLink;
+};
+
+exports.up = function (db, callback) {
+  db.runSql(
+    `ALTER TABLE migration_state ADD PRIMARY KEY (platform_membership_id);
+
+    CREATE INDEX migration_state_pending_idx ON migration_state (state, attempt_count)
+    INCLUDE (platform_membership_id)
+    WHERE state = 1 AND attempt_count < 3;`,
+    callback,
+  );
+};
+
+exports.down = function (db, callback) {
+  db.runSql(
+    `DROP INDEX IF EXISTS migration_state_pending_idx;
+
+    ALTER TABLE migration_state DROP CONSTRAINT migration_state_pkey;`,
+    callback,
+  );
+};
+
+exports._meta = {
+  version: 1,
+};

api/routes/update.ts

@@ -2,6 +2,8 @@ import { captureMessage } from '@sentry/node';
 import { chunk, groupBy, partition, sortBy } from 'es-toolkit';
 import express from 'express';
 import asyncHandler from 'express-async-handler';
+import { transaction } from '../db/index.js';
+import { backfillMigrationState } from '../db/migration-state-queries.js';
 import { metrics } from '../metrics/index.js';
 import { ApiApp } from '../shapes/app.js';
 import { DestinyVersion } from '../shapes/general.js';
@@ -88,6 +90,16 @@ export const updateHandler = asyncHandler(async (req, res) => {
     return;
   }
 
+  // Do a conditional update of the migration state table in Postgres to mark
+  // that we've seen this user and they are in the Stately migration state. This
+  // makes sure new users get put into the migration table while we're
+  // backfilling.
+  if (platformMembershipId) {
+    await transaction(async (client) => {
+      backfillMigrationState(client, platformMembershipId ?? profileIds[0], bungieMembershipId);
+    });
+  }
+
   // const migrationState = await readTransaction(async (client) =>
   //   getMigrationState(client, bungieMembershipId),
   // );