Review comments

Author: edolstra

src/libstore/local-store-active-builds.cc

@@ -84,6 +84,7 @@ static std::set<pid_t> getDescendantPids(pid_t pid)
                     self(*childPid);
         } catch (...) {
             // Process may have exited.
+            ignoreExceptionExceptInterrupt();
         }
     }(pid);
 
@@ -242,7 +243,7 @@ std::vector<ActiveBuildInfo> LocalStore::queryActiveBuilds()
 #endif
 
             result.push_back(std::move(info));
-        } catch (Error &) {
+        } catch (...) {
             ignoreExceptionExceptInterrupt();
         }
     }

src/libutil/table.cc

@@ -19,6 +19,7 @@ void printTable(std::ostream & out, Table & table, unsigned int width)
         assert(i.size() == nrColumns);
         size_t column = 0;
         for (auto j = i.begin(); j != i.end(); ++j, ++column)
+            // TODO: take ANSI escapes into account when calculating width.
             widths[column] = std::max(widths[column], j->content.size());
     }