Skip to content

Commit dcda71e

Browse files
authored
Merge pull request #462 from DeterminateSystems/more-sentry-upload
upload-debug-info-to-sentry.py: Upload binaries in addition to debug files
2 parents b181e64 + e7cd684 commit dcda71e

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

maintainers/upload-debug-info-to-sentry.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,11 @@ def main():
128128
debug_files = []
129129
print("ELF files to process:", file=sys.stderr)
130130
for lib in libs:
131+
debug_files.append(lib)
132+
131133
build_id = get_build_id(lib)
132134
if build_id is None:
133135
print(f" {lib} (no build ID, uploading binary)", file=sys.stderr)
134-
debug_files.append(lib)
135136
continue
136137

137138
local = find_debug_file_in_dirs(build_id, args.debug_dir)
@@ -142,9 +143,9 @@ def main():
142143

143144
debuginfo = fetch_debuginfo(build_id)
144145
if debuginfo is None:
145-
print(f" {lib} ({build_id}): no separate debug info, uploading binary", file=sys.stderr)
146-
debug_files.append(lib)
146+
print(f" {lib} ({build_id}): no separate debug info", file=sys.stderr)
147147
continue
148+
148149
print(f" {lib} ({build_id}): member={debuginfo['member']}", file=sys.stderr)
149150
nar_path = download_nar(build_id, debuginfo["archive"])
150151
debug_file = extract_debug_symbols(nar_path, debuginfo["member"], build_id)

0 commit comments

Comments
 (0)