From 3d701dac6068c72bf4d3fd0047f2556d36d19738 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Mon, 18 May 2026 16:22:31 +0200 Subject: [PATCH 1/2] upload-debug-info-to-sentry.py: Upload binaries in addition to debug files This should provide better stack unwinding in Sentry. --- maintainers/upload-debug-info-to-sentry.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/maintainers/upload-debug-info-to-sentry.py b/maintainers/upload-debug-info-to-sentry.py index 92c3ec03029f..117d8de03d9d 100755 --- a/maintainers/upload-debug-info-to-sentry.py +++ b/maintainers/upload-debug-info-to-sentry.py @@ -128,6 +128,8 @@ def main(): debug_files = [] print("ELF files to process:", file=sys.stderr) for lib in libs: + debug_files.append(lib) + build_id = get_build_id(lib) if build_id is None: print(f" {lib} (no build ID, uploading binary)", file=sys.stderr) @@ -142,9 +144,9 @@ def main(): debuginfo = fetch_debuginfo(build_id) if debuginfo is None: - print(f" {lib} ({build_id}): no separate debug info, uploading binary", file=sys.stderr) - debug_files.append(lib) + print(f" {lib} ({build_id}): no separate debug info", file=sys.stderr) continue + print(f" {lib} ({build_id}): member={debuginfo['member']}", file=sys.stderr) nar_path = download_nar(build_id, debuginfo["archive"]) debug_file = extract_debug_symbols(nar_path, debuginfo["member"], build_id) From e7cd6844cf9c711db97f1dee711e7a82cbf400eb Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Mon, 18 May 2026 16:36:12 +0200 Subject: [PATCH 2/2] Remove duplicate entry --- maintainers/upload-debug-info-to-sentry.py | 1 - 1 file changed, 1 deletion(-) diff --git a/maintainers/upload-debug-info-to-sentry.py b/maintainers/upload-debug-info-to-sentry.py index 117d8de03d9d..87804d32a519 100755 --- a/maintainers/upload-debug-info-to-sentry.py +++ b/maintainers/upload-debug-info-to-sentry.py @@ -133,7 +133,6 @@ def main(): build_id = get_build_id(lib) if build_id is None: print(f" {lib} (no build ID, uploading binary)", file=sys.stderr) - debug_files.append(lib) continue local = find_debug_file_in_dirs(build_id, args.debug_dir)