Skip to content

Canonicalize flake input URLs before checking flake.lock file staleness, for dealing with dir in URL-style flakerefs#57

Merged
edolstra merged 1 commit into
detsys-mainfrom
eelcodolstra/fh-800-assess-impact-of-flakelock-url-change-between-nix-versions
May 8, 2025
Merged

Canonicalize flake input URLs before checking flake.lock file staleness, for dealing with dir in URL-style flakerefs#57
edolstra merged 1 commit into
detsys-mainfrom
eelcodolstra/fh-800-assess-impact-of-flakelock-url-change-between-nix-versions

Conversation

@edolstra
Copy link
Copy Markdown
Collaborator

@edolstra edolstra commented May 8, 2025

Motivation

This prevents Nix from unnecessarily updating lock files created by old versions of Nix that have entries like

"original": {
  "dir": "subdir",
  "type": "git",
  "url": "https:///no-such-path?dir=subdir"
}

Context

@edolstra edolstra force-pushed the eelcodolstra/fh-800-assess-impact-of-flakelock-url-change-between-nix-versions branch from bcbdc50 to bf1c007 Compare May 8, 2025 17:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2025

@github-actions github-actions Bot temporarily deployed to pull request May 8, 2025 17:22 Inactive
@grahamc grahamc changed the title Backward compatibility hack for dealing with dir in URL-style flakerefs Canonicalize flake input URLs before checking flake.lock file staleness, for dealing with dir in URL-style flakerefs May 8, 2025
@edolstra edolstra added this pull request to the merge queue May 8, 2025
Merged via the queue into detsys-main with commit 7c9d25c May 8, 2025
27 checks passed
@edolstra edolstra deleted the eelcodolstra/fh-800-assess-impact-of-flakelock-url-change-between-nix-versions branch May 8, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants