Skip to content

Improve build failure error messages#58

Merged
grahamc merged 1 commit into
detsys-mainfrom
improve-build-failure-error
May 9, 2025
Merged

Improve build failure error messages#58
grahamc merged 1 commit into
detsys-mainfrom
improve-build-failure-error

Conversation

@edolstra

@edolstra edolstra commented May 8, 2025 •
edited by grahamc
Loading

Copy link
Copy Markdown
Collaborator

Motivation

Example output:

image

Compared to the existing:

CleanShot 2025-05-09 at 09 23 41@2x

% nix build .#nestedFailures
warning: Git tree '/Users/grahamc/src/github.com/DeterminateSystems/samples' has uncommitted changes
error: builder for '/nix/store/w37gflm9wz9dcnsgy3sfrmnlvm8qigaj-nested-failure-bottom.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/00gr5hlxfc03x2675w6nn3pwfrz2fr62-nested-failure-middle.drv' failed to build
error: 1 dependencies of derivation '/nix/store/8am0ng1gyx8sbzyr0yx6jd5ix3yy5szc-nested-failure-top.drv' failed to build

Context

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions

github-actions Bot commented May 8, 2025

Copy link
Copy Markdown

🚀 Deployed on https://681d34d42e2cf8814c8b8964--determinate-nix.netlify.app

@github-actions github-actions Bot temporarily deployed to pull request May 8, 2025 22:48 Inactive
grahamc
grahamc reviewed May 9, 2025
View reviewed changes

@grahamc grahamc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-05-09 at 09 36 52@2x

love it!

@grahamc grahamc added this pull request to the merge queue May 9, 2025
Merged via the queue into detsys-main with commit 2903681 May 9, 2025
28 checks passed
@grahamc grahamc deleted the improve-build-failure-error branch May 9, 2025 14:57
@edolstra

edolstra commented May 12, 2025

Copy link
Copy Markdown
Collaborator Author

Upstream PR: NixOS#13169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grahamc grahamc grahamc left review comments

@gustavderdrache gustavderdrache gustavderdrache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edolstra @grahamc @gustavderdrache