Skip to content

Emit warnings when using import-from-derivation by setting the trace-import-from-derivation option to true#70

Merged
grahamc merged 3 commits into
detsys-mainfrom
gustavderdrache/trace-ifd
May 22, 2025
Merged

Emit warnings when using import-from-derivation by setting the trace-import-from-derivation option to true#70
grahamc merged 3 commits into
detsys-mainfrom
gustavderdrache/trace-ifd

Conversation

@gustavderdrache
Copy link
Copy Markdown

@gustavderdrache gustavderdrache commented May 20, 2025

Motivation

While we have the allow-import-from-derivation option to deny IFDs, sometimes users would like to observe IFDs during CI processes to gradually phase the idiom out. This PR adds a trace-import-from-derivation option that, when set, logs a simple warning to the console.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2025

@github-actions github-actions Bot temporarily deployed to pull request May 20, 2025 23:37 Inactive
@github-actions github-actions Bot temporarily deployed to pull request May 21, 2025 16:33 Inactive
@gustavderdrache gustavderdrache marked this pull request as ready for review May 22, 2025 19:16
@grahamc grahamc changed the title Log warnings on IFD with new option Emit warnings when using import-from-derivation by setting the trace-import-from-derivation option to true May 22, 2025
Comment thread src/libexpr/include/nix/expr/eval-settings.hh Outdated
@gustavderdrache gustavderdrache enabled auto-merge May 22, 2025 19:33
@grahamc grahamc disabled auto-merge May 22, 2025 19:34
@github-actions github-actions Bot temporarily deployed to pull request May 22, 2025 19:37 Inactive
@gustavderdrache gustavderdrache force-pushed the gustavderdrache/trace-ifd branch from 432e54b to 0b66fd3 Compare May 22, 2025 21:32
@gustavderdrache gustavderdrache enabled auto-merge May 22, 2025 21:32
@github-actions github-actions Bot temporarily deployed to pull request May 22, 2025 21:41 Inactive
@gustavderdrache gustavderdrache added this pull request to the merge queue May 22, 2025
github-merge-queue Bot pushed a commit that referenced this pull request May 22, 2025
Emit warnings when using import-from-derivation by setting the `trace-import-from-derivation` option to `true`
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 22, 2025
@grahamc grahamc added this pull request to the merge queue May 22, 2025
Merged via the queue into detsys-main with commit f996779 May 22, 2025
26 checks passed
@grahamc grahamc deleted the gustavderdrache/trace-ifd branch May 22, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants