Indicate that sandbox-paths specifies a missing file in the corresponding error message.#88
Merged
cole-h merged 1 commit intoJun 4, 2025
Conversation
grahamc
approved these changes
Jun 4, 2025
cole-h
force-pushed
the
fh-846-improve-nix-error-when-sandbox-path-doesnt-exist
branch
from
6151fe5 to
c5c3377
Compare
edolstra
reviewed
Jun 4, 2025
edolstra
approved these changes
Jun 4, 2025
cole-h
force-pushed
the
fh-846-improve-nix-error-when-sandbox-path-doesnt-exist
branch
from
c5c3377 to
dfa7b2a
Compare
cole-h
deleted the
fh-846-improve-nix-error-when-sandbox-path-doesnt-exist
branch
grahamc
changed the title
brittonr
added a commit
to brittonr/nix
that referenced
this pull request
Mar 16, 2026
Cherry-picked from DeterminateSystems#88, adapted for 2.33.3. In 2.33.3 the sandbox-paths setting is parsed in globals.cc (not derivation-builder.cc as in the DS fork), so the check goes in BaseSetting<PathsInChroot>::parse(). Non-optional paths that don't exist now throw immediately at parse time instead of silently producing a broken sandbox.
brittonr
added a commit
to onixcomputer/onix-core
that referenced
this pull request
Mar 17, 2026
Cherry-picked DeterminateSystems/nix-src#88 onto our wasm-2.33.3 fork. Non-optional sandbox-paths that reference missing files now throw immediately at parse time instead of silently producing a broken sandbox. The hung-downloads fix (DS#327) was skipped — the maxQueueSize pattern it fixes doesn't exist in upstream 2.33.3's filetransfer architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
TODO: