Skip to content

Render lazy tree paths in messages withouth the/nix/store/hash... prefix in substituted source trees#91

Merged
edolstra merged 3 commits into
detsys-mainfrom
fix-substituted-input-path-display
Jun 6, 2025
Merged

Render lazy tree paths in messages withouth the/nix/store/hash... prefix in substituted source trees#91
edolstra merged 3 commits into
detsys-mainfrom
fix-substituted-input-path-display

Conversation

@edolstra
Copy link
Copy Markdown
Collaborator

@edolstra edolstra commented Jun 6, 2025

Motivation

These got displayed as e.g.

«github:NixOS/nixpkgs/...»/nix/store/x9wnkly3k1gkq580m90jjn32q9f05q2v-source/pkgs/stdenv/generic/source-stdenv.sh

Now we get

«github:NixOS/nixpkgs/...»/pkgs/stdenv/generic/source-stdenv.sh

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

edolstra added 2 commits June 6, 2025 19:40
These got displayed as e.g.

  «github:NixOS/nixpkgs/adaa24fbf46737f3f1b5497bf64bae750f82942e?narHash=sha256-qhFMmDkeJX9KJwr5H32f1r7Prs7XbQWtO0h3V0a0rFY%3D»/nix/store/x9wnkly3k1gkq580m90jjn32q9f05q2v-source/pkgs/stdenv/generic/source-stdenv.sh

Now we get

  «github:NixOS/nixpkgs/adaa24fbf46737f3f1b5497bf64bae750f82942e?narHash=sha256-qhFMmDkeJX9KJwr5H32f1r7Prs7XbQWtO0h3V0a0rFY%3D»/pkgs/stdenv/generic/source-stdenv.sh
Comment thread src/libfetchers/fetchers.cc Outdated
Copy link
Copy Markdown
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else lgtm

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2025

@github-actions github-actions Bot temporarily deployed to pull request June 6, 2025 17:58 Inactive
Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
@edolstra edolstra enabled auto-merge June 6, 2025 18:04
@edolstra edolstra added this pull request to the merge queue Jun 6, 2025
@github-actions github-actions Bot temporarily deployed to pull request June 6, 2025 18:14 Inactive
Merged via the queue into detsys-main with commit 0e1df1c Jun 6, 2025
26 checks passed
@edolstra edolstra deleted the fix-substituted-input-path-display branch June 6, 2025 19:05
@grahamc grahamc changed the title Fix rendering of paths in substituted source trees Render lazy tree paths in messages withouth the/nix/store/hash... prefix in substituted source trees Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants