Skip to content

Commit 0789c63

Browse files
committed
ci(test): make the broad dry-run matrix all-required (no optional legs)
The release dry run must be all-green on every platform — drop the optional/continue-on-error flags from the broad matrix legs (ubuntu-22.04, ubuntu-22.04-arm, macos-15, windows-2025) so a failure on any of them gates the run. Only affects broad_platforms=true (the dry run); the core PR-CI matrix is unchanged. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
1 parent 563a663 commit 0789c63

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/_test.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,12 @@ jobs:
3838
{"os":"macos-14","cc":"cc","cxx":"c++"},
3939
{"os":"macos-15-intel","cc":"cc","cxx":"c++"}
4040
]'
41+
# Broad matrix legs are REQUIRED gates (no optional/continue-on-error
42+
# escape hatches): the release dry run must be all-green, every platform.
4143
BROAD_UNIX='[
42-
{"os":"ubuntu-22.04","cc":"gcc","cxx":"g++","optional":true},
43-
{"os":"ubuntu-22.04-arm","cc":"gcc","cxx":"g++","optional":true},
44-
{"os":"macos-15","cc":"cc","cxx":"c++","optional":true}
44+
{"os":"ubuntu-22.04","cc":"gcc","cxx":"g++"},
45+
{"os":"ubuntu-22.04-arm","cc":"gcc","cxx":"g++"},
46+
{"os":"macos-15","cc":"cc","cxx":"c++"}
4547
]'
4648
# Each Windows leg pins the msys2 environment + package arch to the
4749
# RUNNER architecture so the build is native, never emulated:
@@ -53,7 +55,7 @@ jobs:
5355
# the native ARM64 toolchain ASan instruments native ARM64 code, so it
5456
# is a real (non-optional) gate, not a tolerated emulated-flake.
5557
CORE_WIN='[{"os":"windows-latest","msystem":"CLANG64","pkg":"x86_64"}]'
56-
BROAD_WIN='[{"os":"windows-2025","optional":true,"msystem":"CLANG64","pkg":"x86_64"},{"os":"windows-11-arm","msystem":"CLANGARM64","pkg":"aarch64"}]'
58+
BROAD_WIN='[{"os":"windows-2025","msystem":"CLANG64","pkg":"x86_64"},{"os":"windows-11-arm","msystem":"CLANGARM64","pkg":"aarch64"}]'
5759
if [ "$BROAD" = "true" ]; then
5860
UNIX=$(jq -cn --argjson a "$CORE_UNIX" --argjson b "$BROAD_UNIX" '$a + $b')
5961
WIN=$(jq -cn --argjson a "$CORE_WIN" --argjson b "$BROAD_WIN" '$a + $b')

0 commit comments

Comments
 (0)