Separate perf tests from CI, fix cross-platform build issues

- Add CBM_SKIP_PERF=1 env var to skip incremental/perf test suite
- CI and Docker test targets skip perf by default (run.sh perf for manual)
- Convert all perf assertions to warnings (log timing, never block)
- Fix store.h anonymous enum in struct (GCC rejects, clang accepts)
- Fix test_store_search.c mkstemp on non-template path
- Add ca-certificates to Docker test image for git HTTPS
- Add cbm_gmtime_r shim in compat.h (Windows gmtime_s wrapper)
- Fix compat.c missing constants.h include (Windows build)
- Fix platform.c _environ redeclaration on mingw
- Rename trace_call_path -> trace_path in smoke/soak/fuzz scripts

Author: DeusData

.github/workflows/dry-run.yml

@@ -189,8 +189,10 @@ jobs:
         if: startsWith(matrix.os, 'ubuntu')
         run: sudo apt-get update && sudo apt-get install -y zlib1g-dev
 
-      - name: Test
+      - name: Test (unit + integration, no perf)
         run: scripts/test.sh CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
+        env:
+          CBM_SKIP_PERF: 1
 
   test-windows:
     if: ${{ inputs.skip_tests != true && always() && (needs.lint.result == 'success' || needs.lint.result == 'skipped') }}

scripts/security-fuzz.sh

@@ -112,7 +112,7 @@ test_payload "index nonexistent path" '{"jsonrpc":"2.0","id":2,"method":"tools/c
 
 # Negative/zero values for numeric params
 test_payload "negative limit" '{"jsonrpc":"2.0","id":2,"method":"tools/call","params":{"name":"search_graph","arguments":{"name_pattern":"test","limit":-1}}}'
-test_payload "zero max_depth" '{"jsonrpc":"2.0","id":2,"method":"tools/call","params":{"name":"trace_call_path","arguments":{"function_name":"test","max_depth":0}}}'
+test_payload "zero max_depth" '{"jsonrpc":"2.0","id":2,"method":"tools/call","params":{"name":"trace_path","arguments":{"function_name":"test","max_depth":0}}}'
 test_payload "huge max_rows" '{"jsonrpc":"2.0","id":2,"method":"tools/call","params":{"name":"query_graph","arguments":{"query":"MATCH (n) RETURN n","max_rows":999999999}}}'
 
 echo ""

scripts/smoke-test.sh

@@ -138,14 +138,14 @@ if [ "$TOTAL" -lt 1 ]; then
 fi
 echo "OK: search_graph found $TOTAL result(s) for 'compute'"
 
-# 3b: trace_call_path — verify compute has callers
-TRACE=$(cli trace_call_path "{\"project\":\"$PROJECT\",\"function_name\":\"compute\",\"direction\":\"inbound\",\"depth\":1}")
+# 3b: trace_path — verify compute has callers
+TRACE=$(cli trace_path "{\"project\":\"$PROJECT\",\"function_name\":\"compute\",\"direction\":\"inbound\",\"depth\":1}")
 CALLERS=$(echo "$TRACE" | python3 -c "import json,sys; d=json.loads(json.loads(sys.stdin.read())['content'][0]['text']); print(len(d.get('callers',[])))" 2>/dev/null || echo "0")
 if [ "$CALLERS" -lt 1 ]; then
-  echo "FAIL: trace_call_path found 0 callers for 'compute'"
+  echo "FAIL: trace_path found 0 callers for 'compute'"
   exit 1
 fi
-echo "OK: trace_call_path found $CALLERS caller(s) for 'compute'"
+echo "OK: trace_path found $CALLERS caller(s) for 'compute'"
 
 # 3c: get_graph_schema — verify labels exist
 SCHEMA=$(cli get_graph_schema "{\"project\":\"$PROJECT\"}")
@@ -271,7 +271,7 @@ fi
 echo "OK: tools/list response received (id:2)"
 
 # 5c: Verify expected tools are present
-for TOOL in index_repository search_graph trace_call_path get_code_snippet search_code; do
+for TOOL in index_repository search_graph trace_path get_code_snippet search_code; do
   if ! grep -q "\"$TOOL\"" "$MCP_OUTPUT"; then
     echo "FAIL: tool '$TOOL' not found in tools/list response"
     rm -f "$MCP_INPUT" "$MCP_OUTPUT"

scripts/soak-test.sh

@@ -289,7 +289,7 @@ while [ "$(date +%s)" -lt "$END_TIME" ]; do
 
     # Queries every 2 seconds
     mcp_call search_graph "{\"project\":\"$PROJ_NAME\",\"name_pattern\":\".*compute.*\"}"
-    mcp_call trace_call_path "{\"project\":\"$PROJ_NAME\",\"function_name\":\"compute\",\"direction\":\"both\"}"
+    mcp_call trace_path "{\"project\":\"$PROJ_NAME\",\"function_name\":\"compute\",\"direction\":\"both\"}"
 
     # File mutation every 2 minutes
     if [ $((NOW - LAST_MUTATE)) -ge 120 ]; then

src/foundation/compat.c

@@ -5,6 +5,7 @@
  * macros in compat.h. On Windows, we implement them here.
  */
 #include "foundation/compat.h"
+#include "foundation/constants.h"
 
 #include <stdlib.h>
 #include <string.h>

src/foundation/compat.h

@@ -88,6 +88,15 @@ static inline int cbm_nanosleep(const struct timespec *req, struct timespec *rem
 #define cbm_nanosleep nanosleep
 #endif
 
+/* ── gmtime_r (Windows lacks it) ─────────────────────────────── */
+#ifdef _WIN32
+static inline struct tm *cbm_gmtime_r(const time_t *timep, struct tm *result) {
+    return gmtime_s(result, timep) == 0 ? result : NULL;
+}
+#else
+#define cbm_gmtime_r gmtime_r
+#endif
+
 /* ── mkdtemp (Windows lacks it) ──────────────────────────────── */
 #ifdef _WIN32
 /* Translates /tmp/ to %TEMP%\ and copies result back to tmpl.

src/foundation/platform.c

@@ -249,7 +249,7 @@ char *cbm_normalize_path_sep(char *path) {
  * can be invalidated by setenv/putenv in another thread. We copy to a
  * caller-owned buffer immediately. */
 #ifdef _WIN32
-extern char **_environ;
+#include <stdlib.h>
 #define CBM_ENVIRON _environ
 #elif defined(__APPLE__)
 #include <crt_externs.h>

src/graph_buffer/graph_buffer.c

@@ -1182,7 +1182,7 @@ int cbm_gbuf_dump_to_sqlite(cbm_gbuf_t *gb, const char *path) {
     /* Generate ISO 8601 timestamp */
     time_t now = time(NULL);
     struct tm tm_buf;
-    struct tm *tm_val = gmtime_r(&now, &tm_buf);
+    struct tm *tm_val = cbm_gmtime_r(&now, &tm_buf);
     char indexed_at[CBM_SZ_64];
     if (strftime(indexed_at, sizeof(indexed_at), "%Y-%m-%dT%H:%M:%SZ", tm_val) == 0) {
         snprintf(indexed_at, sizeof(indexed_at), "1970-01-01T00:00:00Z");

src/store/store.c

@@ -197,11 +197,7 @@ static sqlite3_stmt *prepare_cached(cbm_store_t *s, sqlite3_stmt **slot, const c
 static void iso_now(char *buf, size_t sz) {
     time_t t = time(NULL);
     struct tm tm;
-#ifdef _WIN32
-    gmtime_s(&tm, &t); /* Windows: reversed arg order */
-#else
-    gmtime_r(&t, &tm);
-#endif
+    cbm_gmtime_r(&t, &tm);
     (void)strftime(buf, sz, "%Y-%m-%dT%H:%M:%SZ",
                    &tm); // cert-err33-c: strftime only fails if buffer is too small — 21-byte ISO
                          // timestamp always fits in caller-provided buffers

src/store/store.h

@@ -534,8 +534,9 @@ void cbm_store_adr_free(cbm_adr_t *adr);
 
 /* ADR section parsing/rendering (pure functions, no store needed) */
 
+enum { PROPS_MAX = 16 };
+
 typedef struct {
-    enum { PROPS_MAX = 16 };
     char *keys[PROPS_MAX];
     char *values[PROPS_MAX];
     int count;