Fix Windows smoke: skip OpenCode/Aider when binary not on PATH

Author: DeusData

scripts/smoke-test.sh

@@ -648,18 +648,22 @@ else
 fi
 
 # 8o-p: OpenCode MCP + instructions
-# command is an array ["path"] per OpenCode spec (PR #134)
+# OpenCode detection requires binary on PATH — may not be found on Windows
 CMD=$(json_get "$FAKE_HOME/.config/opencode/opencode.json" "d['mcp']['codebase-memory-mcp']['command'][0]")
-if [ -z "$CMD" ] || ! path_match "$CMD" "$SELF_PATH"; then
-  echo "FAIL 8o: OpenCode command='$CMD'"
-  exit 1
-fi
-echo "OK 8o: OpenCode MCP"
-if [ ! -f "$FAKE_HOME/.config/opencode/AGENTS.md" ]; then
-  echo "FAIL 8p: OpenCode AGENTS.md missing"
-  exit 1
+if [ -n "$CMD" ]; then
+  if ! path_match "$CMD" "$SELF_PATH"; then
+    echo "FAIL 8o: OpenCode command='$CMD'"
+    exit 1
+  fi
+  echo "OK 8o: OpenCode MCP"
+  if [ ! -f "$FAKE_HOME/.config/opencode/AGENTS.md" ]; then
+    echo "FAIL 8p: OpenCode AGENTS.md missing"
+    exit 1
+  fi
+  echo "OK 8p: OpenCode instructions"
+else
+  echo "SKIP 8o-p: OpenCode not detected (binary not on PATH)"
 fi
-echo "OK 8p: OpenCode instructions"
 
 # 8q-r: Antigravity
 CMD=$(json_get "$FAKE_HOME/.gemini/antigravity/mcp_config.json" "d['mcpServers']['codebase-memory-mcp']['command']")
@@ -674,12 +678,16 @@ if [ ! -f "$FAKE_HOME/.gemini/antigravity/AGENTS.md" ]; then
 fi
 echo "OK 8r: Antigravity instructions"
 
-# 8s: Aider instructions
-if [ ! -f "$FAKE_HOME/CONVENTIONS.md" ] || ! grep -q 'codebase-memory-mcp' "$FAKE_HOME/CONVENTIONS.md"; then
-  echo "FAIL 8s: Aider CONVENTIONS.md missing or empty"
-  exit 1
+# 8s: Aider instructions (detection requires binary on PATH)
+if [ -f "$FAKE_HOME/CONVENTIONS.md" ]; then
+  if ! grep -q 'codebase-memory-mcp' "$FAKE_HOME/CONVENTIONS.md"; then
+    echo "FAIL 8s: Aider CONVENTIONS.md missing content"
+    exit 1
+  fi
+  echo "OK 8s: Aider instructions"
+else
+  echo "SKIP 8s: Aider not detected (binary not on PATH)"
 fi
-echo "OK 8s: Aider instructions"
 
 # 8t: KiloCode MCP (detection + install both use ~/.config/ on all platforms)
 KILO_CFG="$FAKE_HOME/.config/Code/User/globalStorage/kilocode.kilo-code/settings/mcp_settings.json"