Add build scripts, fix GCC warnings, unify CI workflows

DeusData · DeusData · commit fd1640ec2982 · 2026-03-18T12:31:53.000+01:00
- Add scripts/clean.sh, test.sh, build.sh, lint.sh as single source
  of truth for local and CI builds (always clean, always parallel)
- Fix -Wmissing-braces: replace {{0}} with memset for struct arrays
- Fix -Wrestrict: use intermediate buffer for same-struct snprintf
- Update dry-run.yml and release.yml to use the new scripts
diff --git a/.github/workflows/dry-run.yml b/.github/workflows/dry-run.yml
@@ -7,7 +7,7 @@ permissions:
   contents: read
 
 jobs:
-  # ── Step 1: Lint ──────────────────────────────────────────────
+  # ── Step 1: Lint (clang-format + cppcheck) ───────────────────
   lint:
     runs-on: ubuntu-latest
     steps:
@@ -16,15 +16,13 @@ jobs:
       - name: Install build deps
         run: sudo apt-get update && sudo apt-get install -y libsqlite3-dev zlib1g-dev cmake
 
-      # LLVM 20 (clang-format + clang-tidy) from apt.llvm.org
       - name: Install LLVM 20
         run: |
           wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
           echo "deb http://apt.llvm.org/noble/ llvm-toolchain-noble-20 main" | sudo tee /etc/apt/sources.list.d/llvm-20.list
           sudo apt-get update
           sudo apt-get install -y clang-format-20
 
-      # cppcheck 2.20.0 from source (cached)
       - uses: actions/cache@v4
         id: cppcheck-cache
         with:
@@ -42,18 +40,10 @@ jobs:
       - name: Add cppcheck to PATH
         run: echo "/opt/cppcheck/bin" >> "$GITHUB_PATH"
 
-      - name: Verify versions
-        run: |
-          echo "clang-format: $(clang-format-20 --version)"
-          echo "cppcheck: $(cppcheck --version)"
-
-      - name: clang-format
-        run: make -f Makefile.cbm lint-format CLANG_FORMAT=clang-format-20
-
-      - name: cppcheck
-        run: make -f Makefile.cbm lint-cppcheck
+      - name: Lint
+        run: scripts/lint.sh CLANG_FORMAT=clang-format-20
 
-  # ── Step 2: Unit tests (ASan + UBSan) ────────────────────────
+  # ── Step 2: Unit tests (ASan + UBSan) ───────────────────────
   test:
     needs: [lint]
     strategy:
@@ -84,10 +74,10 @@ jobs:
         if: startsWith(matrix.os, 'ubuntu')
         run: sudo apt-get update && sudo apt-get install -y libsqlite3-dev zlib1g-dev
 
-      - name: Run C tests (ASan + UBSan)
-        run: make -j$(nproc 2>/dev/null || sysctl -n hw.ncpu) -f Makefile.cbm test CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
+      - name: Test
+        run: scripts/test.sh CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
 
-  # ── Step 3: Build binaries (standard + UI, all OS) ───────────
+  # ── Step 3: Build binaries (standard + UI, all OS) ──────────
   build-unix:
     needs: [test]
     strategy:
@@ -126,15 +116,15 @@ jobs:
           node-version: "22"
 
       - name: Build standard binary
-        run: make -j$(nproc 2>/dev/null || sysctl -n hw.ncpu) -f Makefile.cbm cbm CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
+        run: scripts/build.sh CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
 
       - name: Archive standard binary
         run: |
           tar -czf codebase-memory-mcp-${{ matrix.goos }}-${{ matrix.goarch }}.tar.gz \
             -C build/c codebase-memory-mcp
 
       - name: Build UI binary
-        run: make -j$(nproc 2>/dev/null || sysctl -n hw.ncpu) -f Makefile.cbm cbm-with-ui CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
+        run: scripts/build.sh --with-ui CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
 
       - name: Archive UI binary
         run: |
@@ -168,7 +158,7 @@ jobs:
 
       - name: Build standard binary
         shell: msys2 {0}
-        run: make -j$(nproc) -f Makefile.cbm cbm
+        run: scripts/build.sh
 
       - name: Archive standard binary
         shell: pwsh
@@ -178,7 +168,7 @@ jobs:
 
       - name: Build UI binary
         shell: msys2 {0}
-        run: make -j$(nproc) -f Makefile.cbm cbm-with-ui
+        run: scripts/build.sh --with-ui
 
       - name: Archive UI binary
         shell: pwsh
@@ -191,7 +181,7 @@ jobs:
           name: binaries-windows-amd64
           path: "*.zip"
 
-  # ── Step 4: Smoke test every binary ──────────────────────────
+  # ── Step 4: Smoke test every binary ─────────────────────────
   smoke-unix:
     needs: [build-unix]
     strategy:
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -21,7 +21,7 @@ permissions:
   contents: write
 
 jobs:
-  # ── Step 1: Lint (clang-format + cppcheck, no clang-tidy) ────
+  # ── Step 1: Lint (clang-format + cppcheck) ───────────────────
   lint:
     runs-on: ubuntu-latest
     steps:
@@ -54,18 +54,10 @@ jobs:
       - name: Add cppcheck to PATH
         run: echo "/opt/cppcheck/bin" >> "$GITHUB_PATH"
 
-      - name: Verify versions
-        run: |
-          echo "clang-format: $(clang-format-20 --version)"
-          echo "cppcheck: $(cppcheck --version)"
-
-      - name: clang-format
-        run: make -f Makefile.cbm lint-format CLANG_FORMAT=clang-format-20
+      - name: Lint
+        run: scripts/lint.sh CLANG_FORMAT=clang-format-20
 
-      - name: cppcheck
-        run: make -f Makefile.cbm lint-cppcheck
-
-  # ── Step 2: Unit tests (ASan + UBSan) ────────────────────────
+  # ── Step 2: Unit tests (ASan + UBSan) ───────────────────────
   test:
     needs: [lint]
     strategy:
@@ -96,10 +88,10 @@ jobs:
         if: startsWith(matrix.os, 'ubuntu')
         run: sudo apt-get update && sudo apt-get install -y libsqlite3-dev zlib1g-dev
 
-      - name: Run C tests (ASan + UBSan)
-        run: make -j$(nproc 2>/dev/null || sysctl -n hw.ncpu) -f Makefile.cbm test CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
+      - name: Test
+        run: scripts/test.sh CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
 
-  # ── Step 3: Build binaries (standard + UI, all OS) ───────────
+  # ── Step 3: Build binaries (standard + UI, all OS) ──────────
   build-unix:
     needs: [test]
     strategy:
@@ -138,27 +130,15 @@ jobs:
           node-version: "22"
 
       - name: Build standard binary
-        env:
-          VERSION: ${{ inputs.version }}
-        run: |
-          CLEAN_VERSION="${VERSION#v}"
-          make -j$(nproc 2>/dev/null || sysctl -n hw.ncpu) -f Makefile.cbm cbm \
-            CC=${{ matrix.cc }} CXX=${{ matrix.cxx }} \
-            CFLAGS_EXTRA="-DCBM_VERSION=\"\\\"$CLEAN_VERSION\\\"\""
+        run: scripts/build.sh --version ${{ inputs.version }} CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
 
       - name: Archive standard binary
         run: |
           tar -czf codebase-memory-mcp-${{ matrix.goos }}-${{ matrix.goarch }}.tar.gz \
             -C build/c codebase-memory-mcp
 
       - name: Build UI binary
-        env:
-          VERSION: ${{ inputs.version }}
-        run: |
-          CLEAN_VERSION="${VERSION#v}"
-          make -j$(nproc 2>/dev/null || sysctl -n hw.ncpu) -f Makefile.cbm cbm-with-ui \
-            CC=${{ matrix.cc }} CXX=${{ matrix.cxx }} \
-            CFLAGS_EXTRA="-DCBM_VERSION=\"\\\"$CLEAN_VERSION\\\"\""
+        run: scripts/build.sh --with-ui --version ${{ inputs.version }} CC=${{ matrix.cc }} CXX=${{ matrix.cxx }}
 
       - name: Archive UI binary
         run: |
@@ -192,12 +172,7 @@ jobs:
 
       - name: Build standard binary
         shell: msys2 {0}
-        env:
-          VERSION: ${{ inputs.version }}
-        run: |
-          CLEAN_VERSION="${VERSION#v}"
-          make -j$(nproc) -f Makefile.cbm cbm \
-            CFLAGS_EXTRA="-DCBM_VERSION=\"\\\"$CLEAN_VERSION\\\"\""
+        run: scripts/build.sh --version ${{ inputs.version }}
 
       - name: Archive standard binary
         shell: pwsh
@@ -207,12 +182,7 @@ jobs:
 
       - name: Build UI binary
         shell: msys2 {0}
-        env:
-          VERSION: ${{ inputs.version }}
-        run: |
-          CLEAN_VERSION="${VERSION#v}"
-          make -j$(nproc) -f Makefile.cbm cbm-with-ui \
-            CFLAGS_EXTRA="-DCBM_VERSION=\"\\\"$CLEAN_VERSION\\\"\""
+        run: scripts/build.sh --with-ui --version ${{ inputs.version }}
 
       - name: Archive UI binary
         shell: pwsh
@@ -225,7 +195,7 @@ jobs:
           name: binaries-windows-amd64
           path: "*.zip"
 
-  # ── Step 4: Smoke test every binary ──────────────────────────
+  # ── Step 4: Smoke test every binary ─────────────────────────
   smoke-unix:
     needs: [build-unix]
     strategy:
@@ -291,7 +261,7 @@ jobs:
         shell: msys2 {0}
         run: scripts/smoke-test.sh ./codebase-memory-mcp.exe
 
-  # ── Step 5: Create GitHub release ────────────────────────────
+  # ── Step 5: Create GitHub release ───────────────────────────
   release:
     needs: [smoke-unix, smoke-windows]
     runs-on: ubuntu-latest
diff --git a/scripts/build.sh b/scripts/build.sh
@@ -0,0 +1,68 @@
+#!/bin/bash
+# build.sh — Clean build of production binary (standard or with UI).
+#
+# Usage:
+#   scripts/build.sh                    # Standard binary
+#   scripts/build.sh --with-ui          # Binary with embedded UI
+#   scripts/build.sh --version v0.8.0   # With version stamp
+#
+# This script is the SINGLE source of truth for building release binaries.
+# Used identically in local development and CI workflows.
+
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "$0")/.." && pwd)"
+cd "$ROOT"
+
+# Detect parallelism
+NPROC=$(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null || echo 4)
+
+# Parse arguments
+WITH_UI=false
+VERSION=""
+EXTRA_MAKE_ARGS=()
+
+while [[ $# -gt 0 ]]; do
+    case "$1" in
+        --with-ui)
+            WITH_UI=true
+            shift
+            ;;
+        --version)
+            VERSION="$2"
+            shift 2
+            ;;
+        CC=*|CXX=*)
+            export "${1?}"
+            EXTRA_MAKE_ARGS+=("$1")
+            shift
+            ;;
+        *)
+            EXTRA_MAKE_ARGS+=("$1")
+            shift
+            ;;
+    esac
+done
+
+# Version flag
+CFLAGS_EXTRA=""
+if [[ -n "$VERSION" ]]; then
+    CLEAN_VERSION="${VERSION#v}"
+    CFLAGS_EXTRA="-DCBM_VERSION=\"\\\"$CLEAN_VERSION\\\"\""
+fi
+
+echo "=== build.sh: compiler=${CC:-default} ui=$WITH_UI version=${VERSION:-dev} cores=$NPROC ==="
+
+# Step 1: Clean C build artifacts only (not node_modules — npm ci handles that)
+rm -rf "$ROOT/build/c"
+
+# Step 2: Build
+if $WITH_UI; then
+    make -j"$NPROC" -f Makefile.cbm cbm-with-ui \
+        CFLAGS_EXTRA="$CFLAGS_EXTRA" "${EXTRA_MAKE_ARGS[@]+"${EXTRA_MAKE_ARGS[@]}"}"
+else
+    make -j"$NPROC" -f Makefile.cbm cbm \
+        CFLAGS_EXTRA="$CFLAGS_EXTRA" "${EXTRA_MAKE_ARGS[@]+"${EXTRA_MAKE_ARGS[@]}"}"
+fi
+
+echo "=== Build complete: build/c/codebase-memory-mcp ==="
diff --git a/scripts/clean.sh b/scripts/clean.sh
@@ -0,0 +1,29 @@
+#!/bin/bash
+# clean.sh — Remove ALL build artifacts, caches, and generated files.
+#
+# Usage: scripts/clean.sh
+#
+# Ensures every subsequent build starts from scratch — no cached .o files,
+# no stale node_modules, no leftover dist folders. This is the first step
+# in both scripts/test.sh and scripts/build.sh.
+
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "$0")/.." && pwd)"
+
+echo "=== Cleaning build artifacts ==="
+
+# C build artifacts
+rm -rf "$ROOT/build/c"
+
+# Frontend build artifacts
+rm -rf "$ROOT/graph-ui/dist"
+rm -rf "$ROOT/graph-ui/node_modules"
+
+# Root-level node artifacts (if any)
+rm -rf "$ROOT/node_modules"
+
+# Generated embedded assets (regenerated by embed-frontend.sh)
+rm -f "$ROOT/src/ui/embedded_assets.c"
+
+echo "=== Clean complete ==="
diff --git a/scripts/lint.sh b/scripts/lint.sh
@@ -0,0 +1,27 @@
+#!/bin/bash
+# lint.sh — Run all CI linters (clang-format + cppcheck).
+#
+# Usage:
+#   scripts/lint.sh                                    # Default tools
+#   scripts/lint.sh CLANG_FORMAT=clang-format-20       # Override formatter
+#
+# This script is the SINGLE source of truth for CI linting.
+# clang-tidy is intentionally excluded (platform-dependent, pre-commit only).
+
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "$0")/.." && pwd)"
+cd "$ROOT"
+
+# Forward overrides from args (e.g. CLANG_FORMAT=clang-format-20)
+MAKE_ARGS=()
+for arg in "$@"; do
+    MAKE_ARGS+=("$arg")
+done
+
+echo "=== lint.sh: running clang-format + cppcheck ==="
+
+# Run format and cppcheck in parallel
+make -j2 -f Makefile.cbm lint-ci "${MAKE_ARGS[@]+"${MAKE_ARGS[@]}"}"
+
+echo "=== All linters passed ==="
diff --git a/scripts/test.sh b/scripts/test.sh
@@ -0,0 +1,35 @@
+#!/bin/bash
+# test.sh — Clean build + run all C tests with ASan + UBSan.
+#
+# Usage: scripts/test.sh [CC=gcc-14] [CXX=g++-14]
+#
+# This script is the SINGLE source of truth for running tests.
+# Used identically in local development and CI workflows.
+#
+# Steps:
+#   1. Clean all build artifacts (forced fresh compile)
+#   2. Build test-runner with sanitizers
+#   3. Run all test suites
+
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "$0")/.." && pwd)"
+cd "$ROOT"
+
+# Detect parallelism
+NPROC=$(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null || echo 4)
+
+# Forward CC/CXX from env or args (e.g. scripts/test.sh CC=gcc-14)
+for arg in "$@"; do
+    export "${arg?}"
+done
+
+echo "=== test.sh: compiler=${CC:-default} cores=$NPROC ==="
+
+# Step 1: Clean
+scripts/clean.sh
+
+# Step 2 + 3: Build and run tests
+make -j"$NPROC" -f Makefile.cbm test
+
+echo "=== All tests passed ==="
diff --git a/src/pipeline/pass_httplinks.c b/src/pipeline/pass_httplinks.c
diff --git a/src/pipeline/pass_infrascan.c b/src/pipeline/pass_infrascan.c
