Skip to content

Commit 08ea316

Browse files
authored
refactor(ci): remove web lint check and clean up workflow (#564)
1 parent a2a220b commit 08ea316

2 files changed

Lines changed: 1 addition & 12 deletions

File tree

.github/scripts/commentResults.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ module.exports = async ({
99
backendTypecheck,
1010
mobileLint,
1111
mobileTest,
12-
webCheck,
1312
webBuild,
1413
backendLintOutput,
1514
mobileLintOutput,
@@ -57,7 +56,6 @@ ${mobileLint === 'failure' ? lintDetails(mobileLintOutput) : ''}
5756
5857
| Check | Result |
5958
|---|---|
60-
| Check | ${status(webCheck)} |
6159
| Build | ${status(webBuild)} |
6260
6361
---

.github/workflows/ci.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ jobs:
9393
runs-on: ubuntu-latest
9494

9595
outputs:
96-
check_result: ${{ steps.web_check.outcome }}
9796
build_result: ${{ steps.web_build.outcome }}
9897

9998
steps:
@@ -108,20 +107,13 @@ jobs:
108107
- name: Install web dependencies
109108
run: npm --prefix apps/web install
110109

111-
- name: Web check
112-
id: web_check
113-
continue-on-error: true
114-
run: npm --prefix apps/web run lint
115-
116110
- name: Web build
117111
id: web_build
118112
continue-on-error: true
119113
run: npm --prefix apps/web run build
120114

121115
- name: Fail job if any check failed
122-
if: >
123-
steps.web_check.outcome == 'failure' ||
124-
steps.web_build.outcome == 'failure'
116+
if: steps.web_build.outcome == 'failure'
125117
run: exit 1
126118

127119
mobile-ci:
@@ -191,7 +183,6 @@ jobs:
191183
backendLint: '${{ needs.backend-ci.outputs.lint_result }}',
192184
backendTest: '${{ needs.backend-ci.outputs.test_result }}',
193185
backendTypecheck: '${{ needs.backend-ci.outputs.typecheck_result }}',
194-
webCheck: '${{ needs.web-ci.outputs.check_result }}',
195186
webBuild: '${{ needs.web-ci.outputs.build_result }}',
196187
mobileLint: '${{ needs.mobile-ci.outputs.lint_result }}',
197188
mobileTest: '${{ needs.mobile-ci.outputs.test_result }}',

0 commit comments

Comments
 (0)