feat: done mass cleanup and reafctoring (#383)

Refactor public routes to utilize service layer for profile and card retrieval; implement caching and error handling improvements

Signed-off-by: Prashantkumar Khatri <prashantkhatri202@gmail.com>

Author: ShantKhatri

apps/backend/src/app.ts

@@ -90,7 +90,9 @@ export async function buildApp():Promise<FastifyInstance> {
   // ─── Auth Decorator ───
   app.decorate('authenticate', async function (request: any, reply: any) {
     try {
-      await request.jwtVerify();
+      // Ensure the verified payload is assigned to `request.user` like the original plugin.
+      const payload = await request.jwtVerify();
+      if (payload) request.user = payload;
     } catch (error) {
       reply.status(401).send({ error: 'Unauthorized' });
     }
@@ -100,8 +102,8 @@ export async function buildApp():Promise<FastifyInstance> {
   await app.register(authRoutes, { prefix: '/auth' });
   await app.register(profileRoutes, { prefix: '/api/profiles' });
   await app.register(cardRoutes, { prefix: '/api/cards' });
+  // Public routes: standardise on `/api/u` (remove duplicate `/api/public`).
   await app.register(publicRoutes, { prefix: '/api/u' });
-  await app.register(publicRoutes, { prefix: '/api/public' });
   await app.register(followRoutes, { prefix: '/api/follow' });
   await app.register(connectRoutes, { prefix: '/api/connect' });
   await app.register(analyticsRoutes, { prefix: '/api/analytics' });
@@ -118,5 +120,20 @@ type HealthResponse = {
 app.get('/health', async (): Promise<HealthResponse> => {
   return { status: 'ok' };
 });
+
+  // Centralized error handler: log and return a consistent 500 shape for unhandled errors.
+  app.setErrorHandler((error, request, reply) => {
+    app.log.error({ err: error }, 'Unhandled error');
+    // Also print to console to aid test diagnostics when logger is disabled.
+    // This helps surface stack traces in CI/test runs.
+    // eslint-disable-next-line no-console
+    console.error(error);
+    // If headers were already sent, fall back to default behaviour.
+    if (reply.sent) {
+      return;
+    }
+    // Keep response shape consistent across the API.
+    reply.status(500).send({ error: 'Internal server error' });
+  });
   return app;
 }

apps/backend/src/env.ts

@@ -8,8 +8,9 @@ const envPath = path.resolve(__dirname, '../../../.env');
 const result = dotenv.config({ path: envPath });
 
 if (result.error) {
-  console.error('❌ Failed to load .env from:', envPath);
-  console.error(result.error);
+  // Keep failing fast but avoid leaking via console in production code paths.
+  // This file runs before the Fastify logger is available; throw so the process exits.
+  throw result.error;
 } else {
-  console.log('✅ Loaded .env from:', envPath);
+  // .env loaded successfully
 }

apps/backend/src/routes/analytics.ts

@@ -12,7 +12,7 @@ export async function analyticsRoutes(
     '/overview',
     {
       // eslint-disable-next-line @typescript-eslint/unbound-method
-      preHandler: [app.authenticate],
+      preHandler: [async (request, reply) => { const server = request.server as any; if (typeof server?.authenticate === 'function') { await server.authenticate(request, reply); return } if (typeof (app as any).authenticate === 'function') { await (app as any).authenticate(request, reply); return } try { await request.jwtVerify() } catch (e) { reply.status(401).send({ error: 'Unauthorized' }) } }],
     },
     async (
       request: FastifyRequest,
@@ -96,7 +96,7 @@ export async function analyticsRoutes(
     '/views',
     {
       // eslint-disable-next-line @typescript-eslint/unbound-method
-      preHandler: [app.authenticate],
+      preHandler: [async (request, reply) => { const server = request.server as any; if (typeof server?.authenticate === 'function') { await server.authenticate(request, reply); return } if (typeof (app as any).authenticate === 'function') { await (app as any).authenticate(request, reply); return } try { await request.jwtVerify() } catch (e) { reply.status(401).send({ error: 'Unauthorized' }) } }],
     },
     async (
       request: FastifyRequest<{