feat(cards): update card creation flow and validation

Author: Harxhit

apps/backend/src/routes/cards.ts

@@ -1,6 +1,6 @@
 import * as cardService from '../services/cardService'
 import { handleDbError } from '../utils/error.util.js';
-import { createCardSchema, updateCardSchema } from '../utils/validators.js';
+import { createCardSchema ,updateCardSchema} from '../validations/card.validation';
 
 import type { CardResponse } from '../services/cardService';
 import type { Card } from '@devcard/shared';
@@ -67,8 +67,7 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {
     }
   });
 
-  // ─── Create Card ───
-
+  // ─── Creates Card ───
   app.post('/', async (request: FastifyRequest<{ Body: CreateCardBody }>, reply: FastifyReply): Promise<Card | void> => {
     const userId = (request.user as { id: string }).id;
     const parsed = createCardSchema.safeParse(request.body);
@@ -81,7 +80,7 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {
       const card = await cardService.createCard(app, userId, parsed.data)
       return reply.status(201).send(card)
     } catch (error: any) {
-      if (error?.code === 'OWNERSHIP') {return reply.status(403).send({ error: 'One or more links do not belong to your account' })}
+      if (error?.code === 'OWNERSHIP'){return reply.status(403).send({ error: 'One or more links do not belong to your account' })}
       return handleDbError(error, request, reply)
     }
   });

apps/backend/src/services/cardService.ts

@@ -1,4 +1,7 @@
-import type { Prisma } from '@prisma/client';
+import { CardVisibility, type Prisma } from '@prisma/client';
+
+import { generateUniqueSlug } from '../utils/slug';
+
 import type { FastifyInstance } from 'fastify';
 
 type CardLinkResponse = { platformLink: unknown };
@@ -25,17 +28,27 @@ export async function listCards(app: FastifyInstance, userId: string): Promise<C
   return cards.map(mapCard);
 }
 
-export async function createCard(app: FastifyInstance, userId: string, body: { title: string; linkIds: string[] }): Promise<CardResponse> {
-  if (body.linkIds.length > 0) {
-    const ownedLinks = await app.prisma.platformLink.findMany({
-      where: { id: { in: body.linkIds }, userId },
-      select: { id: true },
-    });
+export async function createCard(app: FastifyInstance, userId: string, body: { title: string; linkIds: string[] , description?: string, visibility?: CardVisibility}): Promise<CardResponse> {
+  const {title , description , linkIds , visibility} = body
+
+  const ownedLinks = await app.prisma.platformLink.findMany({
+    where: { id: { in: linkIds }, userId },
+    select: { id: true },
+  });
+
+  if (ownedLinks.length !== linkIds.length) {
+    throw Object.assign(new Error('Link ownership mismatch'), { code: 'OWNERSHIP' });
+  } 
+
+  const finalSlug = await generateUniqueSlug(title, async(slug) => {
+    const existing = await app.prisma.card.findUnique({
+      where: {
+        slug
+      }
+    })
+    return !!existing
+  })
 
-    if (ownedLinks.length !== body.linkIds.length) {
-      throw Object.assign(new Error('Link ownership mismatch'), { code: 'OWNERSHIP' });
-    }
-  }
 
   const maxRetries = 3;
   for (let attempt = 1; attempt <= maxRetries; attempt++) {
@@ -47,10 +60,13 @@ export async function createCard(app: FastifyInstance, userId: string, body: { t
           return tx.card.create({
             data: {
               userId,
-              title: body.title,
+              title,
+              slug: finalSlug,
               isDefault: cardCount === 0,
+              description, 
+              visibility: visibility ?? CardVisibility.PUBLIC,
               cardLinks: {
-                create: body.linkIds.map((linkId, index) => ({ platformLinkId: linkId, displayOrder: index })),
+                create: linkIds.map((linkId, index) => ({ platformLinkId: linkId, displayOrder: index })),
               },
             },
             include: { cardLinks: { include: { platformLink: true }, orderBy: { displayOrder: 'asc' } } },
@@ -72,9 +88,8 @@ export async function createCard(app: FastifyInstance, userId: string, body: { t
       ) {
         continue;
       }
-
       app.log.error(error);
-      throw error;
+      throw error
     }
   }
 

apps/backend/src/utils/validators.ts

@@ -45,12 +45,3 @@ export const reorderLinksSchema = z.object({
   ),
 });
 
-export const createCardSchema = z.object({
-  title: z.string().min(1).max(100),
-  linkIds: z.array(z.string().uuid()),
-});
-
-export const updateCardSchema = z.object({
-  title: z.string().min(1).max(100).optional(),
-  linkIds: z.array(z.string().uuid()).optional(),
-});

apps/backend/src/validations/card.validation.ts

@@ -0,0 +1,25 @@
+import { CardVisibility } from '@prisma/client';
+import {z} from 'zod'
+
+export const createCardSchema = z.object({
+  title: z.string().min(1).max(100),
+
+  linkIds: z
+    .array(z.string().uuid())
+    .nonempty({
+      message: 'At least one link is required',
+    })
+    .refine(
+      (ids) => new Set(ids).size === ids.length,
+      {
+        message: 'Duplicate links are not allowed',
+      }
+    ),
+  description: z.string().min(1).max(100).optional(),
+  visibility: z.nativeEnum(CardVisibility).optional(),
+});
+
+export const updateCardSchema = z.object({
+  title: z.string().min(1).max(100).optional(),
+  linkIds: z.array(z.string().uuid()).optional(),
+});