fix(analytics): use followerId to count outbound follows in totalFollows

The totalFollows query in /api/analytics/overview was filtering by 	argetUsername: username (the authenticated user's own DevCard username), but follow.ts writes followLog rows with 	argetUsername = the external platform handle being followed and ollowerId = the actor's user ID.

This mismatch caused totalFollows to always be 0 for real users because no followLog row ever has targetUsername equal to a DevCard username — they hold external handles like GitHub usernames.

Fix: query by ollowerId: userId to correctly count outbound follow actions performed by the authenticated user, which is also what the existing code comment ('Follows performed BY this user') intended.

Also removes the now-unused username destructure from request.user.

Author: hariom888

apps/backend/src/__tests__/analytics.test.ts

@@ -1,20 +1,10 @@
-import {
-  describe,
-  it,
-  expect,
-  beforeEach,
-  afterEach,
-  vi,
-} from 'vitest';
-
-import Fastify, {
-  type FastifyInstance,
-} from 'fastify';
-
-import type { PrismaClient } from '@prisma/client';
+import Fastify, { type FastifyInstance, } from 'fastify';
+import { describe, it, expect, beforeEach, afterEach, vi, } from 'vitest';
 
 import { analyticsRoutes } from '../routes/analytics';
 
+import type { PrismaClient } from '@prisma/client';
+
 // ─── Shared mock data ────────────────────────────────────────────────────────
 
 const MOCK_USER_ID = 'user-001';
@@ -34,7 +24,7 @@ const prismaMock = {
 
 // ─── App factory ─────────────────────────────────────────────────────────────
 
-let mockJwtVerify = vi.fn();
+const mockJwtVerify = vi.fn();
 
 async function buildApp(): Promise<FastifyInstance> {
   const app = Fastify({
@@ -217,6 +207,62 @@ describe(
           }
         );
 
+        it(
+          'totalFollows counts rows by followerId (outbound follows), not by targetUsername',
+          async () => {
+            prismaMock.cardView.count
+              .mockResolvedValueOnce(0)   // totalViews
+              .mockResolvedValueOnce(0);  // viewsToday
+
+            // The user performed 3 outbound follow actions
+            prismaMock.followLog.count.mockResolvedValue(3);
+
+            prismaMock.cardView.findMany.mockResolvedValue([]);
+
+            const res = await app.inject({
+              method: 'GET',
+              url: '/api/analytics/overview',
+              headers: authHeader(),
+            });
+
+            expect(res.statusCode).toBe(200);
+            expect(res.json().totalFollows).toBe(3);
+
+            // Assert the query used followerId, not targetUsername
+            const followCountCall = prismaMock.followLog.count.mock.calls[0][0];
+            expect(followCountCall).toMatchObject({
+              where: {
+                followerId: MOCK_USER_ID,
+                status: 'success',
+              },
+            });
+            expect(followCountCall.where).not.toHaveProperty('targetUsername');
+          }
+        );
+
+        it(
+          'totalFollows is 0 when user has no successful outbound follows',
+          async () => {
+            prismaMock.cardView.count
+              .mockResolvedValueOnce(50)
+              .mockResolvedValueOnce(5);
+
+            // No successful follow rows for this user
+            prismaMock.followLog.count.mockResolvedValue(0);
+
+            prismaMock.cardView.findMany.mockResolvedValue([]);
+
+            const res = await app.inject({
+              method: 'GET',
+              url: '/api/analytics/overview',
+              headers: authHeader(),
+            });
+
+            expect(res.statusCode).toBe(200);
+            expect(res.json().totalFollows).toBe(0);
+          }
+        );
+
         it(
           '401 — rejects unauthenticated request',
           async () => {

apps/backend/src/routes/analytics.ts

@@ -19,8 +19,7 @@ export async function analyticsRoutes(
       request: FastifyRequest,
       _reply: FastifyReply
     ) => {
-      const userId = request.user.id;
-      const username = request.user.username;
+      const userId = (request.user as any).id;
 
       const today = new Date();
       today.setHours(0, 0, 0, 0);
@@ -39,10 +38,10 @@ export async function analyticsRoutes(
           },
         }),
 
-        // Follows performed BY this user
+        // Follows performed BY this user (outbound follow actions where this user is the actor)
         app.prisma.followLog.count({
           where: {
-            targetUsername: username,
+            followerId: userId,
             status: 'success',
           },
         }),