Docs/add contributing guide - #697
Closed
Nareshkumawat-star wants to merge 6 commits into
Closed
Conversation
|
Someone is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
Contributor
CI — All Checks PassedBackend — PASS
Mobile — SKIP
Web — PASS
Last updated: |
Signed-off-by: Nareshkumawat-star <nareshkmt112006@gmail.com>
…preHandlers, and typecast profile tx
Collaborator
|
This PR is deviated from the issue. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request introduces a comprehensive
CONTRIBUTING.mdguide in the repository root to help new contributors set up the project locally, understand the monorepo architecture, follow branch naming conventions, and adhere to PR quality checklists. Additionally, it fixes a bug in the backend GET/api/events/:slugendpoint that was causing a test failure by exposing the missingorganizerIdfield in the response.#Closes : #619
Type of Change
What Changed
CONTRIBUTING.md(root): Added a new structured contributing guide containing a monorepo project overview, prerequisite software requirements, step-by-step local setup guide, branch naming conventions (feat/,fix/,docs/,chore/), PR quality checklist, and an issue labels guide.apps/backend/src/routes/event.ts: Modified theEventDetailstype and updated the GET/:slugendpoint response mapping to includeorganizerId: details.organizerId. This resolves the assertion error in the backend test suite whereorganizerIdwas received asundefined.node:cryptoimports) to ensure they are tracked.How to Test
npm run test