Skip to content

fix(cards): remove any usages in cards route - #621

Merged
Harxhit merged 4 commits into
Dev-Card:mainfrom
keerthana266:fix/remove-any-cards-route
Jun 24, 2026
Merged

fix(cards): remove any usages in cards route#621
Harxhit merged 4 commits into
Dev-Card:mainfrom
keerthana266:fix/remove-any-cards-route

Conversation

@keerthana266

@keerthana266 keerthana266 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Description

Removed any usages from apps/backend/src/routes/cards.ts
and replaced them with proper Fastify typings.

Changes Made

  • Removed request.server as any
  • Removed (app as any).authenticate
  • Used FastifyInstance.authenticate typing from fastify.d.ts

Type of Change

@vercel

vercel Bot commented Jun 20, 2026

Copy link
Copy Markdown

@keerthana266 is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @keerthana266,

Thanks for opening this pull request.

This PR has been automatically classified based on the files modified.

Applied Labels

  • gssoc:approved
  • backend

Primary Review Area

  • backend

Reviewer

@Harxhit has been identified as the primary reviewer for this pull request.

If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer.

Thank you for your contribution!

@github-actions github-actions Bot added backend gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. labels Jun 20, 2026
@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

CI — All Checks Passed

Backend — PASS

Check Result
Lint PASS
Test PASS
Typecheck PASS

Mobile — SKIP

Check Result
Lint -
Test -

Web — SKIP

Check Result
Build -

Last updated: Tue, 23 Jun 2026 13:54:52 GMT

@keerthana266

Copy link
Copy Markdown
Contributor Author

I investigated the failing typecheck.

Running npm --prefix apps/backend run typecheck on the current main branch produces the same Cannot find module '@devcard/shared' errors in multiple files (cards.ts, follow.ts, team.ts, profileService.ts, and validators.ts).

The changes in this PR are limited to removing any usages from cards.ts and handling error types safely. The remaining typecheck failures appear to be present in the base branch as well.

@Harxhit

Harxhit commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

@keerthana266 Please mentioned which issue it closes on PR description.

@keerthana266

Copy link
Copy Markdown
Contributor Author

@keerthana266 Please mentioned which issue it closes on PR description.

Hi @Harxhit,

This PR addresses the same type-safety improvements in cards.ts, but issue #547 was already assigned, completed, and closed via #579 before I opened this PR.

Could you please let me know if you'd like me to link this PR to a different open issue, or should I simply mark it as related to #547?

Thanks!

@Harxhit

Harxhit commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@keerthana266 Typecheck is failing could you please look into it.

@keerthana266

Copy link
Copy Markdown
Contributor Author

Hi @Harxhit,

I merged the latest upstream/main into this branch, resolved the conflicts, regenerated the Prisma client, and verified locally that backend typecheck passes.

The backend-ci check is now passing successfully. The only remaining blocker appears to be the Vercel authorization/review requirement.

Could you please take a look when you have time?

Thanks!

@Harxhit Harxhit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving

@Harxhit
Harxhit merged commit affea61 into Dev-Card:main Jun 24, 2026
5 of 6 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Congratulations @keerthana266 on getting PR #621 merged!

Thank you for your contribution to the project.

To receive the appropriate GSSoC labels and recognition, please mention @Harxhit in the #get-labels channel on our Discord server and share your merged PR link.

@keerthana266

Copy link
Copy Markdown
Contributor Author

@Harxhit Hi, I am unable to access the Discord server. Could you please guide me on how GSSoC contributions are tracked for this PR? Also, I’ve ensured the issue is linked and PR is merged.

@Harxhit

Harxhit commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

@Harxhit Hi, I am unable to access the Discord server. Could you please guide me on how GSSoC contributions are tracked for this PR? Also, I’ve ensured the issue is linked and PR is merged.

https://discord.gg/wF46Q24Bz -> Link for the discord you can find all the details in the discord server.

@Harxhit Harxhit added level:intermediate Moderate difficulty contribution requiring some project understanding. (+35 pts) quality:clean PR is well-structured, readable, and follows good practices. (×1.2 multiplier) type:performance Performance optimization (+15 pts) type:refactor Code refactoring/cleanup (+10 pts) type:bug Bug fixes (+10 pts) labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. level:intermediate Moderate difficulty contribution requiring some project understanding. (+35 pts) quality:clean PR is well-structured, readable, and follows good practices. (×1.2 multiplier) type:bug Bug fixes (+10 pts) type:performance Performance optimization (+15 pts) type:refactor Code refactoring/cleanup (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants