delphi fixup

Author: NickVolynkin

Delphi/PDFReportGenerator.dpr

@@ -5,13 +5,12 @@ program PDFReportGenerator;
 {$R *.res}
 
 uses
-  System.SysUtils,
-  System.Classes,
-  dxBackend,                     // DevExpress Reports and Dashboards backend
-  dxBackend.Bundled,
-  dxBackend.ConnectionString.SQL,
-  dxReport,                      // DevExpress Reports frontend
-  dxReport.Parameters;
+  System.SysUtils, System.Classes, System.StrUtils, dxBackend, dxBackend.Bundled,
+  dxBackend.ConnectionString.SQL, dxReport, dxReport.Parameters;
+var
+  AParameter: TArray<string>;
+  i: Integer;
+  AOrderID, Key, Value: string;
 
 // Export a report to a PDF file in non-interactive mode:
 // without showing the report in the Report Designer or Report Viewer, or otherwise using UI.
@@ -24,6 +23,7 @@ var
   AReportParameter: TdxReportParameter;
   AStream: TMemoryStream;
   AOutputFileName: string;
+
 begin
   // Step 1: Create a report instance and load the report layout
   AReport := TdxReport.Create(nil);
@@ -68,37 +68,27 @@ end;
 
 // The helper application entry point that parses command-line parameters and calls the export procedure
 begin
-  var
-    AOrderID, AParam: string;
-    Key, Value: string;
-    i: Integer;
-  try
-    AOrderID := ''; // Initialize as empty
-
-    // Parse command-line parameters in the format "key=value"
-    for i := 1 to ParamCount do
+  AOrderID := ''; // Initialize as empty
+  // Parse command-line parameters in the format "key=value"
+  for i := 1 to ParamCount do
+  begin
+    if ParamStr(i).Contains('=') then
     begin
-      AParam := ParamStr(i);
-      if AParam.Contains('=') then
-      begin
-        Key := Copy(AParam, 1, Pos('=', AParam) - 1).ToLower;
-        Value := Copy(AParam, Pos('=', AParam) + 1, Length(AParam));
-
-        if Key = 'orderid' then
-          AOrderID := Value;
-      end;
-    end;
+      AParameter := SplitString(ParamStr(i), '=');
+      Key := AParameter[0].ToLower;
+      Value := AParameter[1];
 
-    // Check if AOrderID is provided
-    if AOrderID.IsEmpty then
-    begin
-      Writeln('Error: OrderID parameter is required. For example: PDFReportGenerator.exe orderid=11077');
-      Halt(1); // Exit with error code 1
+      if Key = 'orderid' then
+        AOrderID := Value;
     end;
+  end;
 
-    ExportReportToPdf(AOrderID);
-  except
-    on E: Exception do
-      Writeln(E.ClassName, ': ', E.Message);
+  // Check if AOrderID is provided
+  if AOrderID.IsEmpty then
+  begin
+    Writeln('Error: OrderID parameter is required. For example: PDFReportGenerator.exe orderid=11077');
+    Halt(1); // Exit with error code 1
   end;
+
+  ExportReportToPdf(AOrderID);
 end.